[HOLD for payment 2024-11-07] [HybridApp] Exporting to CSV does not save any file to iOS device

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5087705
Email or phone of affected tester (no customers): gatanm+1010@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch the app logged with an account with a few expenses
2. Tap on Search tab
3. Tap and hold on any expense and tap Select
4. Select a few more expenses by tapping on the checkmark
5. Tap on the "seclected" dropdown and Download
6. Search for a downloaded file

Expected Result:

A CSV file is generated and can be seen in the dowloaded files on iOS

Actual Result:

A pop up message that was saved is shown but no file can be seen on iOS Files app

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6635803_1729029297716.ScreenRecording_10-16-2024_00-44-09_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-bills

[IuliiaHerets]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[trjExpensify]

Oh hm, is it in some folder called "Expensify" or something? CC: @rlinoz as I think we had this issue before.

[rlinoz]

Yeah, we discussed it here https://expensify.slack.com/archives/C036QM0SLJK/p1721321098444739?thread_ts=1721057271.106449&cid=C036QM0SLJK but I never created an issue.

If this is the same thing let's use this issue to improve the message

[trjExpensify]

I can repro this bug though. I'm not seeing the download on my iOS device. 🤔

[trjExpensify]

Specifically, HybridApp.

[rlinoz]

I plan to setup the HybridApp in my dev environment between today and tomorrow and then test/fix this one.

[rlinoz]

Got the app running, investigating now why it works for NewDot and doesn't for Hybrid.

[rlinoz]

If we want to keep things as they are, we would have to add a few settings to the HybridApp which would expose the app's folder, the same way we do for NewDot, but in the Old app we save quite a lot of stuff in there and I think it would be best not to expose the folder, as this could be confusing for the user and lead to some bugs if files get deleted by accident.

I think we can go with the approach of allowing the user to save the file wherever they want as we previously discussed:

Screen.Recording.2024-10-22.at.14.00.23.mov

cc: @trjExpensify @Expensify/design

[trjExpensify]

I think we can go with the approach of allowing the user to save the file wherever they want as we previously discussed:

yeah, I don't see why we wouldn't give them the choice. Do you? That's what I'd expect when I download to my device.

[rlinoz]

None that I can think of, I will open a PR with this changes then

[shawnborton]

Yeah, that approach makes sense to me too.

[trjExpensify]

Wahoo, nice to get that PR merged!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Adds folder picker when downloading CSV on iOS #51290

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment through NewDot Manual Requests

[melvin-bot]

@alitoshmatov @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[trjExpensify]

Checklist time, @alitoshmatov!

[alitoshmatov]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Appeared only HybridApp due to how HybridApp was setup

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Can't pinpoint exact PR, have to do with HybrydApp settings which I don't have full access

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: No discussion

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

This is not a new test case, we changed behavior of file download where we can now choose where to download file(see step 6). I think existing test for this case should be updated

Test:

1. Launch the app logged with an account with a few expenses
2. Tap on Search tab
3. Tap and hold on any expense and tap Select
4. Select a few more expenses by tapping on the checkmark
5. Tap on the "selected" dropdown and Download
6. Verify that on iOS you can choose where to download the file to
7. Open the Files app and verify the file is downloaded

Do we agree 👍 or 👎

[alitoshmatov]

Requested payment on newDot

P. S. first time receiving payment here, let me know if any action needed from me

[JmillsExpensify]

Ready to approve the NewDot payment, though I need a payment summary in this GH issue first.

[trjExpensify]

Payment summary as follows:

• $250 to @alitoshmatov for the C+ review

Go ahead and request.

[trjExpensify]

As for the regression test, this is the existing test. Shall I add the the step in bold then, @rlinoz @alitoshmatov? Everything else rings true? (Especially step 9).

1. Navigate to the Search page by clicking the search icon with a bill in the bottom navigation bar
2. Click on the Expenses option
3. Select a few expenses from the list
4. Verify there's a top right menu that indicates how many items have been selected
5. Click on the menu
6. Verify there's an option to download
7. Click download
8. [iOS] Verify you can choose where to download the file to
9. Verify a CSV file named Expensify__.csv is downloaded to your local device

[JmillsExpensify]

$250 approved for @alitoshmatov

[trjExpensify]

Cool, regression test edit requested. Closing!