Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Chat - The size of avatar that is displayed when chat starts, or top of the chat is 108x108 #50385

Closed
1 of 6 tasks
IuliiaHerets opened this issue Oct 8, 2024 · 5 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #49555
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to personal chat and check if icon is of 100x100 size
  2. Go to group chat and check if icon is of 100x100 size
  3. Go to workspace chat and check if icon is of 100x100 size

Expected Result:

The icon size for every chat is 100x100

Actual Result:

The icon size for every chat is 108x108

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6628032_1728371324500!photo_2024-10-08_08-49-20
Bug6628032_1728371324482!photo_2024-10-08_08-49-15
Bug6628032_1728371324494!photo_2024-10-08_08-49-03

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 8, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Oct 8, 2024

I think this is not a bug because if we inspect go through the svg avatar we can see the size is 100x100, and why when we hover the size of the avatar is showing 108x108, because there's a wrapper div on top of the svg with border-width 4px

@MariaHCD
Copy link
Contributor

MariaHCD commented Oct 8, 2024

Thanks, @NJ-2020! Agreed.

The SVG itself is 100 x 100:

Screenshot 2024-10-08 at 5 42 04 PM

But it is nested within a div with a border width of 4px:

Screenshot 2024-10-08 at 5 44 42 PM

@MariaHCD MariaHCD closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants