Distance rates - Change Rate to default leads to app crash

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #49194
Email or phone of affected tester (no customers): applausetester+bp0911del@app;ause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Preconditions:

1. Track tax is enabled.
2. Workspace has at least two distance rates that have tax rate and tax reclaimable on
3. Each distance rate has different tax rate

Steps to reproduce:

1. Go to ws chat > Submit expense
2. Choose Distance > enter waypoints
3. Submit expense
4. Go to expense details > click on Rate
5. Choose Default Rate (0,67 / mile)

Expected Result:

User is navigated to expense details page. Chosen rate is displayed.

Actual Result:

Android app: application crashes

Web/mWeb/Desktop app: user stays on Rate tab. Default Rate is checked, but previous rate is highlighted. User need to click/tap on default rate again.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1909_2.txt

Bug6608698_1726740199922.Screenrecorder-2024-09-19-12-52-06-277.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

📣 @abhisharma9876! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

📣 @aroopcodder! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[IuliiaHerets]

We think that this bug might be related to #vip-bills

[dylanexpensify]

reviewing

[grgia]

https://expensify.slack.com/archives/C01GTK53T8Q/p1726745325381519

[mountiny]

definitely related to this firebase crash https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues/022302da0d55dfb152b0c7d7d51a24a7?time=last-seven-days&types=crash&versions=9.0.38-0%20(1009003800)&sessionEventKey=66EC079701C80001114740D23489E14D_1994770182356551182

[carlosmiceli]

@Krishna2323 @aimane-chnaif Can you look into this?

[carlosmiceli]

@mountiny This would qualify as revert-worthy if we don't solve it soon, right?

[carlosmiceli]

These are the firebase crash logs:

Fatal Exception: com.facebook.react.common.JavascriptException: TypeError: Cannot read property 'value' of undefined, js engine: hermes, stack:
getModifiedExpenseOriginalMessage@1:2641368
buildOptimisticModifiedExpenseReportAction@1:2657263
getUpdateMoneyRequestParams@1:2928286
updateMoneyRequestDistanceRate@1:2935771
selectDistanceRate@1:6750319
t12@1:6750366
selectRow@1:5374828
anonymous@1:5376736
anonymous@1:4219664
onSelectRow@1:5376708
onPress@1:4199364
t23@1:4218512
anonymous@1:4219664
_performTransitionSideEffects@1:791974
_receiveSignal@1:791562
onResponderRelease@1:790391
executeDispatch@1:1250761
executeDispatchesAndReleaseTopLevel@1:1256047
forEachAccumulated@1:1252277
anonymous@1:1256485
batchedUpdatesImpl@1:1317425
batchedUpdates$1@1:1255971
dispatchEvent@1:1256250

at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java:65)
at com.facebook.jni.NativeRunnable.run(NativeRunnable.java)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
at android.os.Looper.loopOnce(Looper.java:205)
at android.os.Looper.loop(Looper.java:294)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:235)
at java.lang.Thread.run(Thread.java:1012)

[mountiny]

@carlosmiceli yes probably worth to revert #49194

[Krishna2323]

@mountiny, sorry for delay, give me a moment to check this.

[Krishna2323]

@mountiny @carlosmiceli, should I raise a PR?

Here we added taxAmount and taxCode in transactionChanges so it is also sent to the backend through params, object. We only need to update the values optimistically so I think we can remove the taxAmount and taxCode properties from the params object. WDYT?

App/src/libs/actions/IOU.ts

Lines 3166 to 3192 in 040c801

	function updateMoneyRequestDistanceRate(
	transactionID: string,
	transactionThreadReportID: string,
	rateID: string,
	policy: OnyxEntry<OnyxTypes.Policy>,
	policyTagList: OnyxEntry<OnyxTypes.PolicyTagLists>,
	policyCategories: OnyxEntry<OnyxTypes.PolicyCategories>,
	taxAmount?: number,
	taxCode?: string,
	) {
	const transactionChanges: TransactionChanges = {
	customUnitRateID: rateID,
	...(taxAmount ? {taxAmount} : {}),
	...(taxCode ? {taxCode} : {}),
	};
	const allReports = ReportConnection.getAllReports();
	const transactionThreadReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReportID}`] ?? null;
	const parentReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReport?.parentReportID}`] ?? null;
	let data: UpdateMoneyRequestData;
	if (ReportUtils.isTrackExpenseReport(transactionThreadReport) && ReportUtils.isSelfDM(parentReport)) {
	data = getUpdateTrackExpenseParams(transactionID, transactionThreadReportID, transactionChanges, true, policy);
	} else {
	data = getUpdateMoneyRequestParams(transactionID, transactionThreadReportID, transactionChanges, policy, policyTagList, policyCategories, true);
	}
	const {params, onyxData} = data;
	API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DISTANCE_RATE, params, onyxData);
	}

[grgia]

@Krishna2323 yes, could you please raise a PR?

[Krishna2323]

Okay, raising a PR in few minutes.

[Krishna2323]

PR is up, adding videos in few minutes.

[carlosmiceli]

PR fix is now merged, thanks @Krishna2323 !

[dylanexpensify]

Woooo!

[melvin-bot]

@carlosmiceli, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[carlosmiceli]

@dylanexpensify this is in prod already, can we close?