[HOLD for payment 2025-01-15] [$125] [Pending / Scanning] If multiple receipts are scanning in a report, update the copy of the preview component to be plural (i.e. "receipts scanning")

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1726065881464109

Action Performed:

1. Create a workspace
2. Scan a receipt and submit it to that workspace
3. Immediately scan another receipt and submit it to that workspace

Expected Result:

The report preview component should say "Receipts scanning" as there are multiple on the report

Actual Result:

The report preview says "Receipt scanning"

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834189848594534997
• Upwork Job ID: 1834189848594534997
• Last Price Increase: 2024-12-10
• Automatic offers:
• nyomanjyotisa | Contributor | 105368332

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[trjExpensify]

Should be a simple task.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834189848594534997

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-12 11:23:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

If multiple receipts are scanning in a report, update the copy of the preview component to be plural

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

Here we can add another check numberOfScanningReceipts

App/src/components/ReportActionItem/ReportPreview.tsx

Line 241 in ef6a64c

const getDisplayAmount = (): string => {

if numberOfScanningReceipts > 1 we can show new text Receipts scanning. We also need to add this in en.ts and es.ts file

What alternative solutions did you explore? (Optional)

We can make directly changes in es.ts and en.ts files we can do something like this

    receiptScanning: (numberOfScanningReceipts) =>{
          return numberOfScanningReceipts > 1 ?  'Receipts scanning...'  :  'Receipt scanning...'
        },

[nyomanjyotisa]

Edited by proposal-police: This proposal was edited at 2024-12-16 13:01:12 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

If multiple receipts are scanning in a report, update the copy of the preview component to be plural

What is the root cause of that problem?

We don't make the iou.receiptScanning translation to handle plural and singular form

What changes do you think we should make in order to solve the problem?

Update the iou.receiptScanning translation on both en and es to accept plural and singular form

        receiptScanning: () => ({
            one: 'Receipt scanning...',
            other: 'Receipts scanning...',
        }),

        receiptScanning: () => ({
            one: 'Escaneando recibo...',
            other: 'Escaneando recibos...',
        }),

Update this code to pass the count param using numberOfScanningReceipts

return translate('iou.receiptScanning', {count: numberOfScanningReceipts});

Do the same for other iou.receiptScanning translation implementation here here here here and here

What alternative solutions did you explore? (Optional)

[Nodebrute]

Note for C+: My alternate solution was added 1 minute before @nyomanjyotisa

[HezekielT]

I think there is an open PR already here #48229 that handles Plural forms

cc @ZhenjaHorbach

[ZhenjaHorbach]

I think there is an open PR already here #48229 that handles Plural forms

cc @ZhenjaHorbach

Good point !
Thanks for mentioning

Bu it would be better to ask @shubham1206agra's opinion
What do you think?
Maybe you have already encountered similar issue
And can we just close this issue in favor of a more global PR or or leave this issue ?

[Nodebrute]

Hi @ZhenjaHorbach, your PR is already handling so many files. We've encountered a similar situation in the past where the team decided to keep these changes separate. For reference: #48412 (comment)

[ZhenjaHorbach]

Hi @ZhenjaHorbach, your PR is already handling so many files. We've encountered a similar situation in the past where the team decided to keep these changes separate. For reference: #48412 (comment)

Actually my PR just prepares translations for the use of plural forms 😅
But we have another PR where we use plural forms

So I don't have much context
But thank you for pointing out a similar case !
In this case, yes, similar issues can be fixed in separate PRs like here !

[shubham1206agra]

No, this is directly related to pluralization. So we will handle this.

[trjExpensify]

Sorry, it's unclear what you mean. Are we moving forward with a PR for this issue or is it being taken care of elsewhere?

[melvin-bot]

📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update the text in the preview component to be plural if multiple receipts are being scanned #54274

If no regressions arise, payment will be issued on 2025-01-15. 🎊

For reference, here are some details about the assignees on this issue:

• @nyomanjyotisa requires payment automatic offer (Contributor)
• @eh2077 requires payment through NewDot Manual Requests
• @kevinksullivan requires payment (Needs manual offer from BZ)

[melvin-bot]

@eh2077 @isabelastisser @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[MariaHCD]

Not overdue - we just need the BZ checklist to move forward here

[isabelastisser]

BugZero Checklist:

• [@eh2077 ] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [@eh2077 ] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [@eh2077 ] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [@isabelastisser ] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[isabelastisser]

@eh2077, please complete the checklist before the payment can be processed. Thanks!

[isabelastisser]

Bump @eh2077 to complete the checklist. Thanks!

[eh2077]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/24235/files#r1918697408

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

No, we don't need to add regression test here because the fix is straightforward.

[eh2077]

@isabelastisser Done, thanks for the ping!

[isabelastisser]

Payment summary:

@nyomanjyotisa automatic offer (Contributor) $125 - paid in Upwork.
@eh2077 requires payment through NewDot Manual Requests C+ $125 pending

[shubham1206agra]

@isabelastisser The issue is marked for $125. Can you double-check the payment summary?

[isabelastisser]

@shubham1206agra, my confusion, sorry! updated!

[JmillsExpensify]

$125 approved for @eh2077