Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-01][Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread #48882

Closed
2 of 6 tasks
IuliiaHerets opened this issue Sep 10, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Sep 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.31-12
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch New Expensify app.
  2. Go to any report.
  3. Send a message.
  4. Send a reply to the message in thread.
  5. Go to Search.
  6. Go to Chats.
  7. Tap on the parent message sent in Step 3.
  8. Tap on the reply count to go to thread.
  9. Return to LHN by swiping to right twice (iOS navigation) (if on Android, use device back navigation and not app button).
  10. Tap Search.

Expected Result:

Search icon will be responsive after returning to LHN from thread when opened from Search.

Actual Result:

Search icon is not responsive after returning to LHN from thread when opened from Search.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6598333_1725946650814.ScreenRecording_09-10-2024_13-33-05_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @sakluger
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 10, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Sep 10, 2024

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 10, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@pecanoro
Copy link
Contributor

pecanoro commented Sep 10, 2024

I managed to reproduce it. Unlike one-level chats that return to the search view when swiping right, if you navigate to a thread, it will go back to the LHN. Maybe that's the issue here.

@pecanoro
Copy link
Contributor

Most likely coming from #47690

@luacmartins
Copy link
Contributor

luacmartins commented Sep 10, 2024

This is also reproducible in production (when navigating from Transaction thread > Expense report and then swiping right). So not specific to chat nor a PR in this deploy cycle. I think we can demote this and fix it as a follow up cc @WojtekBoman @Kicu @adamgrzybowski @289Adam289

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 10, 2024
@luacmartins luacmartins changed the title Android & iOS - Search - Search icon is not responsive after returning to LHN from thread [Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread Sep 10, 2024
@luacmartins
Copy link
Contributor

@pecanoro I can also take this issue if you want, since it's part of the Search project

@pecanoro
Copy link
Contributor

Sure, feel free to do so since you have more context!

@pecanoro pecanoro removed their assignment Sep 12, 2024
@luacmartins luacmartins moved this from Polish to Done in [#whatsnext] #expense Sep 19, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Oct 7, 2024
Copy link

melvin-bot bot commented Oct 7, 2024

This issue has not been updated in over 15 days. @sakluger, @luacmartins, @ishpaul777 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@ishpaul777
Copy link
Contributor

this is ready for payment @sakluger ^, i reviewed #48990 and PR author was agency member so only c+ payment due

@luacmartins luacmartins changed the title [Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread [HOLD for payment 2024-10-01][Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread Oct 9, 2024
@luacmartins luacmartins added Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 and removed Reviewing Has a PR in review Monthly KSv2 labels Oct 9, 2024
@luacmartins
Copy link
Contributor

@sakluger just missing PR review payment to C+

@sakluger sakluger added the Internal Requires API changes or must be handled by Expensify staff label Oct 9, 2024
@sakluger
Copy link
Contributor

sakluger commented Oct 9, 2024

@luacmartins thanks for the bump.

@ishpaul777 please let me know once you've accepted the offer: https://www.upwork.com/nx/wm/offer/104347535

@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@sakluger
Copy link
Contributor

The contract was accepted and I paid it out. We're all done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
Status: Done
Development

No branches or pull requests

5 participants