[HOLD for payment 2024-11-21] [$250] iOS Invoices - Blank area under composer after returning from workspace page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30-7
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #48014
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• User has sent invoice to the receiver and receiver has paid the invoice.

1. Launch New Expensify app.
2. Open invoice chat as the invoice sender.
3. Tap on the invoice preview.
4. Tap on the composer to bring up keyboard.
5. Tap Add bank account.
6. Return to the invoice report.

Expected Result:

There will not be a blank area under the composer if keyboard is not up.

Actual Result:

There is a blank area under the composer when keyboard is not up after returning from workspace page.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6594706_1725576434622.ScreenRecording_09-06-2024_06-42-27_1.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831977574854649069
• Upwork Job ID: 1831977574854649069
• Last Price Increase: 2024-10-17
• Automatic offers:
• QichenZhu | Contributor | 104516887

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mjasikowski]

on it

[mjasikowski]

per conversation with @mountiny, demoting this one since it's minor UI issue which can be worked around (the user can tap on the composer field to bring the keyboard back up) and this occurs on a single platform only

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831977574854649069

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Upwork job price has been updated to $125

[ryalinikhil]

Modify the view lifecycle methods to handle layout recalculations.
Listen to keyboard notifications (UIKeyboardWillShowNotification, UIKeyboardWillHideNotification) to adjust the composer’s frame.

[melvin-bot]

📣 @ryalinikhil! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[QichenZhu]

I can still reproduce this.

RPReplay_Final1729663356-2024-10-23.06_04_02.531.1.mp4

The upstream PR facebook/react-native#46952 is merged but not released yet. It might take months.

Could we put this on hold if it’s not urgent? Otherwise a patch might be more efficient.

[melvin-bot]

@mjasikowski, @fedirjh, @muttmuure, @QichenZhu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mjasikowski]

@QichenZhu can you create a PR with the patch? After that we'll make this issue monthly, put it on hold and will remove the patch once React Native 0.76 arrives.

[fedirjh]

Not overdue.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix KeyboardAvoidingView not aware of the keyboard closing after it is unmounted #51509

If no regressions arise, payment will be issued on 2024-11-21. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment through NewDot Manual Requests
• @QichenZhu requires payment automatic offer (Contributor)

[melvin-bot]

@fedirjh @muttmuure @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[muttmuure]

$250 - @fedirjh C+
$250 @QichenZhu C

[fedirjh]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1d. Upstream bug (react-native)
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A , This is an upstream bug : Fix KeyboardAvoidingView not aware of the keyboard closing after it is unmounted facebook/react-native#46952

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Precondition: User has sent invoice to the receiver and receiver has paid the invoice.

Test:

1. Launch New Expensify app on IOS native
2. Open invoice chat as the invoice sender.
3. Tap on the invoice preview.
4. Tap on the composer to bring up keyboard.
5. Tap Add bank account.
6. Return to the invoice report.
7. Verify there is no blank area under the composer if keyboard is not up.

Do we agree 👍 or 👎

[melvin-bot]

@mjasikowski, @fedirjh, @muttmuure, @QichenZhu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[garrettmknight]

$250 approved for @fedirjh