[HOLD for payment 2024-09-17][$250] [Search v2.2] Create chat filter - Is

[luacmartins]

Implement this section of the design doc for the is filter only! It should accept two values: unread, pinned (we're descoping draft for now since that's not saved on the server)

This is a type=chat specific filter, so the UI should only render it if the user is currently viewing the chat type.

cc @289Adam289 @Kicu @Guccio163

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015684aa45795e5b82
• Upwork Job ID: 1828194742989624421
• Last Price Increase: 2024-08-26

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @SzymczakJ

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the Bug assigner, not assigning anyone new.

[joekaufmanexpensify]

@luacmartins should this be external for proposals, or are the folks you tagged in OP working on it?

[luacmartins]

SWM will work on this.

[joekaufmanexpensify]

Got it, sounds good!

[joekaufmanexpensify]

@289Adam289 @Kicu @Guccio163 could whoever is working on this comment on the issue so I can assign them to the issue?

[Kicu]

hey guys what is the difference between this Is filter and the one from v2.1: #46030 ?
Or is this a duplicate?

For now everyone in SWM/Search is working on other search tasks and finishing up 2 filters from v2.1, so we'll pick this one up once someone is free.

[luacmartins]

@JmillsExpensify we decided to remove the UI filter for type/status. The is filter is kind of a status filter, do we need to support is in the UI as well? Or is this just a syntax filter?

[joekaufmanexpensify]

Pending prioritization by SWM

[joekaufmanexpensify]

As an fyi, going to be OOO from tomorrow - Monday. Not adding another BZ since nothing should be needed during that time. Please ask in slack if something comes up.

[JmillsExpensify]

@JmillsExpensify we decided to remove the UI filter for type/status. The is filter is kind of a status filter, do we need to support is in the UI as well? Or is this just a syntax filter?

I ended up answering this question in the doc and I agree with your answer. Looks like we'll still implement the syntax under the hood and it'll show it in the UI (via tab bar or what we call "contextual tabs."

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

[melvin-bot]

@luacmartins, @joekaufmanexpensify Huh... This is 4 days overdue. Who can take care of this?

[joekaufmanexpensify]

Sounds great, TY! I see the draft PR, is there an ETA for it to be in review?

[joekaufmanexpensify]

Still pending other PR being merged

[melvin-bot]

@luacmartins, @joekaufmanexpensify, @ikevin127, @SzymczakJ Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[SzymczakJ]

Still pending other PR being merged

[SzymczakJ]

Since I've run out of things to work on and "Has" filter is already merged(and it was also depending on chat type PR) I decided that this PR can be moved forward(to test we just need to set one value in Onyx, just like we did in "Has" filter). It's ready for C+ review.

[joekaufmanexpensify]

PR merged and on staging

[luacmartins]

PR was deployed to production yesterday.

[joekaufmanexpensify]

Sounds good! Will pay on the 17th.

[joekaufmanexpensify]

Payment due tomorrow. Only payment here is $250 to @ikevin127 for C+ review via Upwork

[joekaufmanexpensify]

@ikevin127 offer sent for $250!

[joekaufmanexpensify]

All set to issue payment.

[joekaufmanexpensify]

@ikevin127 $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set. TY everyone!