Update Payment flow on clicking Pay

[madmax330]

Part of the project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.u0rlixqcmug6
Project: https://github.com/orgs/Expensify/projects/114

Feature Description

Relevant doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.jxlg73mn39np

Manual Test Steps

Create an invoice, as the receiver click on pay and make sure the different dialogs work correctly.

Automated Tests

Issue Owner

Current Issue Owner: @rezkiy37

[madmax330]

We might want to split this one up into different PRs for each of the different payment methods

[danielrvidal]

@madmax330 any updates on this one? We'll probably have to make some progress to hit SuiteWorld, not sure if it's been tracked somewhere else.

[madmax330]

Going to work on it this week, I think it's holding on some backend changes

[madmax330]

Changing to weekly so I can get this done

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[rezkiy37]

Actively working on the issue.

[madmax330]

Not overdue

[madmax330]

Still working on the Auth part

[rezkiy37]

I am OOO till Tuesday and will continue to work on this issue later.

[rezkiy37]

Waiting for the backend.

[rezkiy37]

Waiting for the backend.

[cristipaval]

Just had a chat with @madmax330 and we chatted about the error that is thrown from the backend.

[cristipaval]

Posting here for me whenever I have time to work again on this:

• We currently throw here when the payer has no Stripe customer ID
• We need to check in peek() whether the payer has that ID and create it when they don't, using the Stripe::createCustomer function from Stripe.cpp.

[cristipaval]

Calm down, Melv

[rezkiy37]

I've synced the PR up and solved eslint errors.

[cristipaval]

I'm still swamped with external-commit-related work. If this week was an ideal one, I would be able to work on this in a few days

[rezkiy37]

@cristipaval, any updates? I've synced the PR up.

[cristipaval]

I might work on this sometime these days.

[rezkiy37]

I’m planning a short vacation next week from Monday to Wednesday, from the 17th to the 19th. I am working on the issue later.

[cristipaval]

I have a WIP PR

[rezkiy37]

I’m planning a day off next week on Monday. I am working on the issue later.

[rezkiy37]

I am back. Working on the issue.

[cristipaval]

The Auth PR is ready for review. When it hits production, we can continue the work on the front-end

[cristipaval]

Update

The Auth PR is merged. It should be deployed tomorrow in the afternoon.

[rezkiy37]

@cristipaval, I just tested it and had a new error - 404 Stripe customerID does not exist. Has the auth PR been deployed? If yes, what's wrong with my requests?

Details

requestID: "91c2b7e0499db32a-SJC"

requestID: "91c2b81f9a78f986-PRG"

[cristipaval]

@rezkiy37, we had some issues with the deployment today. The Auth PR hasn't been deployed yet. There will be an automatic comment informing us when it is live.

[cristipaval]

Oh, the automatic comment didn't come, because the PR is from another repo.

The changes are live as of now.

[rezkiy37]

@cristipaval, I can confirm I've tested the changes. However, I still have errors.

Error 666 - wrong currency

As I understand the currency must be the same as a policy uses. It fails even if I use the correct currency for an invoice.

Error 500 - Stripe

I suspect that the backend system cannot recognize my bank accounts as legitimate.

Please test my PR on your side with the correct bank accounts. I will open the PR for review if it works properly for you.

[cristipaval]

@rezkiy37, I forgot to let you know that Stripe payments work with USD currency only. So we'll have to hide the Pay with Expensify option for the reports that have other currency.

[rezkiy37]

I've opened #50640 for review.