-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-19] Enabling Invoices as a feature on the workspace #45168
Comments
Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue. |
Preparing the draft PR. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-19. 🎊 |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
@madmax330 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@madmax330 Huh... This is 4 days overdue. Who can take care of this? |
@madmax330 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
@madmax330 I noticed that even when it's enabled, I'm still seeing Send Invoice in my global create. Is that intentional or being covered in another issue? |
@danielrvidal, yes. FYI: #47023, #47023 (comment). |
@madmax330 10 days overdue. I'm getting more depressed than Marvin. |
Will look into this, I think we need to pay the c+ for the PR review |
@madmax330 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Will figure out the payment |
@madmax330 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@madmax330 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Triggered auto assignment to @isabelastisser ( |
@isabelastisser can you arrange the payment for the PR Review for this to @dukenv0307 |
Sure! @dukenv0307, I sent you an offer in Upwork. Thanks! |
@isabelastisser Thank you I accepted |
Part of the Invoice project
Main issue: https://github.com/Expensify/Expensify/issues/382977
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.jpplu5rcslex
Project: https://github.com/orgs/Expensify/projects/114
Feature Description
This feature allows users to enable invoicing for their workspaces by adding a toggle in the workspace.
Manual Test Steps
Go to workspace settings and enable invoicing and the toggle should remain on
Disable it and it should be toggle off.
Check that the parameter is correctly saved in the workspace data in onyx
Automated Tests
The text was updated successfully, but these errors were encountered: