Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-19] Enabling Invoices as a feature on the workspace #45168

Closed
madmax330 opened this issue Jul 10, 2024 · 21 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@madmax330
Copy link
Contributor

Part of the Invoice project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.jpplu5rcslex
Project: https://github.com/orgs/Expensify/projects/114

Feature Description

This feature allows users to enable invoicing for their workspaces by adding a toggle in the workspace.

Screenshot 2024-07-10 at 7 22 57 PM

Manual Test Steps

Go to workspace settings and enable invoicing and the toggle should remain on
Disable it and it should be toggle off.
Check that the parameter is correctly saved in the workspace data in onyx

Automated Tests

@rezkiy37
Copy link
Contributor

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 1, 2024

Preparing the draft PR.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Aug 6, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 12, 2024
@melvin-bot melvin-bot bot changed the title Enabling Invoices as a feature on the workspace [HOLD for payment 2024-08-19] Enabling Invoices as a feature on the workspace Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-19. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 18, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Copy link

melvin-bot bot commented Aug 21, 2024

@madmax330 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Aug 23, 2024

@madmax330 Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Aug 27, 2024

@madmax330 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@danielrvidal
Copy link
Contributor

@madmax330 I noticed that even when it's enabled, I'm still seeing Send Invoice in my global create. Is that intentional or being covered in another issue?

@danielrvidal danielrvidal moved this from Low to Critical in [#whatsnext] #billpay Aug 27, 2024
@rezkiy37
Copy link
Contributor

@danielrvidal, yes. FYI: #47023, #47023 (comment).

Copy link

melvin-bot bot commented Aug 29, 2024

@madmax330 10 days overdue. I'm getting more depressed than Marvin.

@madmax330
Copy link
Contributor Author

Will look into this, I think we need to pay the c+ for the PR review

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 2, 2024
Copy link

melvin-bot bot commented Sep 5, 2024

@madmax330 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@madmax330
Copy link
Contributor Author

Will figure out the payment

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 9, 2024
Copy link

melvin-bot bot commented Sep 12, 2024

@madmax330 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Sep 16, 2024

@madmax330 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@madmax330 madmax330 added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 17, 2024
Copy link

melvin-bot bot commented Sep 17, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@madmax330
Copy link
Contributor Author

@isabelastisser can you arrange the payment for the PR Review for this to @dukenv0307

@isabelastisser
Copy link
Contributor

Sure!

@dukenv0307, I sent you an offer in Upwork. Thanks!

@github-project-automation github-project-automation bot moved this from Critical to Done in [#whatsnext] #billpay Sep 19, 2024
@dukenv0307
Copy link
Contributor

@isabelastisser Thank you I accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants