[HOLD FOR PAYMENT 2024-07-15] Expense - Missing report title in report details page after the expense is paid

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat with no unsettled expense
3. Submit an expense
4. Go to transaction thread
5. Pay the expense (same account as admin)
6. Click on the report header

Expected Result:

There will be report title in report details page after the expense is paid

Actual Result:

There is no report title in report details page after the expense is paid

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6535806_1720442348996.untitled.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mkhutornyi

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@srikarparsi FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Missing report title in report details page after the expense is paid.

What is the root cause of that problem?

In the existing logic, neither nameSectionExpenseIOU is being shown nor nameSectionTitleField.

This is because shouldShowTitleField is true and titleField is undefined.

App/src/pages/ReportDetailsPage.tsx

Lines 646 to 651 in e0ccba5

	<View style={[styles.reportDetailsTitleContainer, styles.pb0]}>
	{renderedAvatar}
	{isExpenseReport && !shouldShowTitleField && nameSectionExpenseIOU}
	</View>
	{isExpenseReport && shouldShowTitleField && nameSectionTitleField}

shouldShowTitleField being true dismisses the possibility of showing nameSectionExpenseIOU.

titleField being undefined dismisses the possibility of showing nameSectionTitleField .

What changes do you think we should make in order to solve the problem?

If titleField is not available, then we should show nameSectionExpenseIOU.

<View style={[styles.reportDetailsTitleContainer, styles.pb0]}>
    {renderedAvatar}
    {isExpenseReport && (!shouldShowTitleField || !titleField) && nameSectionExpenseIOU}
</View>

{isExpenseReport && shouldShowTitleField && titleField && nameSectionTitleField}

[ShridharGoel]

@mountiny @srikarparsi I'm available to quickly open a PR to fix this.

[Julesssss]

Thanks @ShridharGoel, I'm not familiar with this flow but your logic makes sense to me. Please go ahead and submit a PR

[Julesssss]

Possibly related to the edit report title PR.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ShridharGoel]

#44973

[allroundexperts]

@Julesssss can you assign this to me? Thanks!

[johncschuster]

@Julesssss just making sure I'm following along correctly – the PR that I should be watching for regressions is #44973, right?

[Julesssss]

Hey @johncschuster. Yep that's correct 👍

[johncschuster]

Thanks! Looks like it was approved on July 8, so I will pay this out on July 15 assuming no regressions 👍

[johncschuster]

No regressions! I'll get this paid out today.

[johncschuster]

Payment Summary:

Contributor+: @allroundexperts - $250 - paid via Manual request
Contributor: @ShridharGoel - $250 - paid via Upwork

[johncschuster]

@ShridharGoel, can you accept the job linked above so I can issue payment?

[johncschuster]

Bumped in Slack 👍

[johncschuster]

Upwork job has not been accepted yet. Holding on that.

[johncschuster]

Payment has been issued to @ShridharGoel! @allroundexperts, please request payment via ND if you haven't already done so.

[JmillsExpensify]

$250 approved for @allroundexperts