[HOLD for payment 2024-07-10] [$250] [LOW] fast-equal lib Imported dependency is not listed in the package.json

[gedu]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: -
Email or phone of affected tester (no customers): -
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kacper-mikolajczak
Slack conversation: https://callstack-hq.slack.com/archives/C01GTK53T8Q/p1718732844064939

Action Performed:

Break down in numbered steps

The crash happens when you try to use Onyx using the build:watch function:

1. In one terminal tab, open the react-native-onyx directory and run npm run build:watch
2. In another terminal tab, open your React Native project and run npx link publish <path_to_onyx_directory_on_your_machine>
3. Then run your React Native project as normal!

Expected Result:

Describe what you think should've happened

The App should run successfully

Actual Result:

Describe what actually happened

The app Crash because it can't find the fast-equals module

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Yes, you can keep using it

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0183ec865fba64bd1b
• Upwork Job ID: 1803424421263671850
• Last Price Increase: 2024-06-19

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gedu]

Hey, I'm Edu from callstack, I want to work on this issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0183ec865fba64bd1b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Add fast-equals as dependency #44018

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @gedu does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)
• @kacper-mikolajczak does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah] Determine if we should create a regression test for this bug.
• [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

@JmillsExpensify $250 to @rayane-djouah and we can close this

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @gedu is from an agency-contributor and not due payment
• ROLE: @rayane-djouah paid $250 via Upwork

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1803424421263671850/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

Payment summary above is correct! $250 to @rayane-djouah. I just sent you an Upwork offer.

[rayane-d]

@JmillsExpensify - Accepted the offer. Thank you!

[JmillsExpensify]

All paid out!