[HOLD FOR PAYMENT] [$250] Categorizing - RHP closes instead of returning to category list after deleting a category

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.82-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace has disabled all the categories

1. Go to staging.new.expensify.com
2. Go to FAB > Track expense > Manual
3. Track a manual expense
4. Click Categorize it from the actionable whisper
5. Select the workspace that has disabled all the categories
6. Click Edit categories
7. Click on any category
8. Click Delete
9. Delete the category

Expected Result:

RHP will return to category list after deleting a category

Actual Result:

RHP closes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6511282_1718221899351.20240613_034743.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0138b0b86909b7d865
• Upwork Job ID: 1802749240400742682
• Last Price Increase: 2024-06-24
• Automatic offers:
• Krishna2323 | Contributor | 102863915

Issue Owner

Current Issue Owner: @Krishna2323

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categorizing - RHP closes instead of returning to category list after deleting a category

What is the root cause of that problem?

We dismiss the modal when the deletion is confirmed.

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Lines 70 to 74 in a451de4

	const deleteCategory = () => {
	Category.deleteWorkspaceCategories(route.params.policyID, [route.params.categoryName]);
	setDeleteCategoryConfirmModalVisible(false);
	Navigation.dismissModal();
	};

What changes do you think we should make in order to solve the problem?

We can either apply the same logic used in the HeaderWithBackButton onBackButtonPress callback or can simply call Navigation.goBack() instead of Navigation.dismissModal();.

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Line 91 in a451de4

onBackButtonPress={() => (backTo ? Navigation.goBack(ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute(route.params.policyID, backTo)) : Navigation.goBack())}

What alternative solutions did you explore? (Optional)

We can check for backTo and if not present call Navigation.dismissModal();.

    const deleteCategory = () => {
        Category.deleteWorkspaceCategories(route.params.policyID, [route.params.categoryName]);
        setDeleteCategoryConfirmModalVisible(false);
        if (backTo) {
            Navigation.goBack(ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute(route.params.policyID, backTo));
            return;
        }
        Navigation.dismissModal();
    };

Result

category_modal_closed.mp4

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categorizing - RHP closes instead of returning to category list after deleting a category

What is the root cause of that problem?

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Lines 70 to 73 in a451de4

	const deleteCategory = () => {
	Category.deleteWorkspaceCategories(route.params.policyID, [route.params.categoryName]);
	setDeleteCategoryConfirmModalVisible(false);
	Navigation.dismissModal();

We always dismiss modal after deleting the category

What changes do you think we should make in order to solve the problem?

We ought to avoid employing the dismissModal function for pages that could serve as both the central pane and the right-hand pane. Instead, we should devise a function specifically for managing the goBack action for the CategorySettingsPage.

const goBack = () => {
        if (backTo) {
            Navigation.goBack(ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute(route.params.policyID, backTo))
            return
        }   
        Navigation.goBack()
}

And utilizing this function in these places

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Line 73 in a451de4

Navigation.dismissModal();

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Line 91 in a451de4

onBackButtonPress={() => (backTo ? Navigation.goBack(ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute(route.params.policyID, backTo)) : Navigation.goBack())}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0138b0b86909b7d865

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

@garrettmknight, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[garrettmknight]

Reassigning C+ since Sibtain is out - @eVoloshchak can you take a look at this one?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[garrettmknight]

@eVoloshchak bump when you get a chance. Thanks!

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@allroundexperts, PR ready for review ^

[Krishna2323]

@allroundexperts friendly bump for a review.

[allroundexperts]

@garrettmknight Can you please assign this issue (and the PR) to me? It slipped from my K2 because of this.

[francoisl]

Assigned you @allroundexperts. Will you review the PR too?

[allroundexperts]

Yes, please assign the PR to me as well.

[Krishna2323]

@garrettmknight, PR was deployed to production on 16 July, this is ready for payments.

[allroundexperts]

Checklist

1. feat: Delete single category #38379
2. https://github.com/Expensify/App/pull/38379/files#r1694783270
3. N/A
4. A regression test would be good.

Regression Test

Pre-req: Workspace has disabled all the categories

1. Open the app and Go to FAB -> Track expense -> Manual
2. Track a manual expense
3. Click Categorize it from the actionable whisper
4. Select the workspace that has disabled all the categories
5. Click Edit categories and click on any category
6. Click Delete and delete the category

Verify that the RHP will return to category list after deleting a category

Do we 👍 or 👎 ?

[Krishna2323]

@garrettmknight, friendly bump for payments.

[Krishna2323]

@garrettmknight, friendly bump for payments. @allroundexperts can you pls bump this on slack? thanks

[garrettmknight]

@Krishna2323 sorry about this one, on it now!

[garrettmknight]

Payment Summary:

• Contributor: @Krishna2323 $250 paid via upwork
• Reviewer: @allroundexperts $250

[garrettmknight]

Leaving weekly for payment request @allroundexperts

[allroundexperts]

@garrettmknight I have noted this down for payment. Feel free to close the issue.

[JmillsExpensify]

$250 approved for @allroundexperts