[$250] [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [LOW] [Performance] Improve the performance of getOrderedReportIDs

[mountiny]

Coming from here

Problem

Constantly copying all reports in the getOrderedReportIDs function is resource-intensive. We're doing this just to add a single property, and we are using only 2 copied properties. This process significantly increases the function's runtime.

report = {
    ...report,
    displayName: ReportUtils.getReportName(report),
};

Solution

Avoid copying the entire report object. Instead, create a minimized report version that only includes the necessary properties. This approach is safe as these data are used solely for sorting.

type MiniReport = {
    reportID?: string;
    displayName: string;
    lastVisibleActionCreated?: string;
};
// ...

const miniReport: MiniReport = {
    reportID: report?.reportID,
    displayName: ReportUtils.getReportName(report),
    lastVisibleActionCreated: report?.lastVisibleActionCreated,
};

On my heavy account, I've tested it, and here are the results:

• getOrderedReportIDs function call time: 36% improvement in performance, reduced from 185ms (SD 3ms) → 118ms (SD 8ms), n = 10, measured in the code,
• ReportIDsContextProvider render time: 28% improvement in performance, reduced from 233ms (SD 4ms) → 168ms (SD 2ms), n = 3, measured using a profiler,

A POC with performance measurements is available here. Please let me know if you have any questions.

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01facc6fcf70a639b9
• Upwork Job ID: 1805325257306582163
• Last Price Increase: 2024-06-24

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

@kosmydel will take this one

[joekaufmanexpensify]

@kosmydel please comment and I'll assign you

[kosmydel]

Commenting :)

[mountiny]

PR in review

[joekaufmanexpensify]

About to go OOO until 2024-06-25, but don't think payment will be due before then, so not adding an additional assignee. Please re-add bug label if someone comes up in the interim while I am away.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Performance] Improve getOrderedReportIDs performance #43539

If no regressions arise, payment will be issued on 2024-06-24. 🎊

For reference, here are some details about the assignees on this issue:

• @kosmydel does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@kosmydel] Determine if we should create a regression test for this bug.
• [@kosmydel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Performance] Improve getOrderedReportIDs performance #43539

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @kosmydel does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@kosmydel] Determine if we should create a regression test for this bug.
• [@kosmydel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[joekaufmanexpensify]

@shubham1206agra mind commenting here so I can assign you? I see you were C+ for this one

[shubham1206agra]

👋🏽

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01facc6fcf70a639b9

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[joekaufmanexpensify]

@shubham1206agra is checklist needed here?

[joekaufmanexpensify]

Only payment here is $250 to @shubham1206agra via upwork for C+

[joekaufmanexpensify]

@shubham1206agra offer sent for $250!

[shubham1206agra]

@shubham1206agra is checklist needed here?

No

[shubham1206agra]

@shubham1206agra offer sent for $250!

@joekaufmanexpensify Accepted

[joekaufmanexpensify]

Great! All set to pay then.

[joekaufmanexpensify]

@shubham1206agra $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set, thanks everyone!