Hold-Full report gets approved automatically even if there is an expense on hold

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.79-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4593480
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions: Create A WS and add an Employee and a Approver
As the Employee, submit couple of expenses

1. Open the App
2. Log in as the Approver
3. Open the WS chat and put an expense on hold
4. Navigate back to the expense report that now has a held expense and a pending expense and click approve

Expected Result:

A modal is displayed to approve the full report amount or just the pending expense

Actual Result:

The report is automatically fully approved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6502515_1717578950875.expenseapp.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nkdengineer]

Will be fixed here #42896.

[isabelastisser]

Thanks for the heads up, @nkdengineer! Closing.