Investigate workflow job failing on main: confirmPassingBuild

[github-actions]

🚨 Failure Summary 🚨:

• 📋 Job Name: confirmPassingBuild
• 🔧 Failure in Workflow: Process new code merged to main
• 🔗 Triggered by PR: PR Link
• 👤 PR Author: @ZhenjaHorbach
• 🤝 Merged by: @grgia
• 🐛 Error Message:
  failure: Process completed with exit code 1.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named confirmPassingBuild.
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

1. Why the PR caused the job to fail?
2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

[Julesssss]

Submitting a new PR with the conflict resolve will fix this

[ZhenjaHorbach]

@Julesssss
Hello )
A little unclear issue
As far as I understand, to the extent that we have TS issues, we cannot complete confirmPassingBuild job?

[Julesssss]

That CI check is done after the PR changes are merged into main. it wasn't flagged on the PR, because the typescript check is run in isolation against the PR changes, and doesn't include recent changes from other PRs recently merged into main.

This isn't a big problem, we just need to branch from main and resolve the failing TS check. We can reduce these occurrences by merging main into PRs shortly before they are approved and merged. But we will never prevent 100% of them.

[Julesssss]

Seems like this was expected to happen, by this comment from @tienifr

// @ts-expect-error TODO: Remove this once TestHelper (https://github.com/Expensify/App/issues/25318) is migrated to TypeScript.

[ZhenjaHorbach]

Seems like this was expected to happen, by this comment from @tienifr

// @ts-expect-error TODO: Remove this once TestHelper (https://github.com/Expensify/App/issues/25318) is migrated to TypeScript.

#42256

I already made PR )

And it's my fault
I didn't update the branch before merging

And I'm thinking
Maybe we should update CI so that after approval we update the branch to the latest changes from the main ?
And in case of lint or TS problems, we simply ignore approve

[Julesssss]

Thanks. We've talked about that, but it could still occur if the discussions occur after approval, and it slows down approval/merging. We can talk about it again in the future though if this is annoying everyone.