Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd #41914

Closed
mountiny opened this issue May 9, 2024 · 37 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented May 9, 2024

### Problem

The workspace profile page showcases the workspace avatar, name, description and currency. This data is not loaded when we navigate to this page which can lead to potentially outdated.

This is also not aligned with other policy settings pages, where we fetch the up-to-date data when we navigate to the page ieOpenWorkspaceMembersPage

Solution

Create a new OpenWorkspaceProfilePage to follow the 1:1:1 which will read the necessary data for the profile page anytime we navigate to it.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012e913b6015edda5e
  • Upwork Job ID: 1788566297116684288
  • Last Price Increase: 2024-05-09
Issue OwnerCurrent Issue Owner: @zanyrenney
@mountiny mountiny added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels May 9, 2024
@mountiny mountiny self-assigned this May 9, 2024
Copy link

melvin-bot bot commented May 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012e913b6015edda5e

Copy link

melvin-bot bot commented May 9, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

Copy link

melvin-bot bot commented May 9, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@mountiny
Copy link
Contributor Author

I will look into this today or tomorrow

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
@melvin-bot melvin-bot bot added the Overdue label May 15, 2024
@zanyrenney
Copy link
Contributor

hows it going @mountiny ?

@melvin-bot melvin-bot bot removed the Overdue label May 16, 2024
@zanyrenney
Copy link
Contributor

@mountiny is OOO- we will pick back up next week

@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@zanyrenney
Copy link
Contributor

bump for when you're back @mountiny

@melvin-bot melvin-bot bot removed the Overdue label May 20, 2024
@mountiny
Copy link
Contributor Author

I am looking into if there are any performance tasks I can help with as a priority now, then I will pick this back up

@melvin-bot melvin-bot bot added the Overdue label May 22, 2024
Copy link

melvin-bot bot commented May 23, 2024

@mountiny @fedirjh @zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented May 23, 2024

@mountiny, @fedirjh, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor Author

Focusing on higher priority tasks, but this is on my list

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 23, 2024
Copy link

melvin-bot bot commented May 27, 2024

@mountiny, @fedirjh, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny
Copy link
Contributor Author

On my list still for this week

@zanyrenney
Copy link
Contributor

payment summary

@fedirjh requires payment through NewDot Manual Requests - please request $250 via ND.

@hungvu193
Copy link
Contributor

@zanyrenney I reviewed the PR can you please update the Payment summary.
The first PR was reverted so @fedirjh created a revised PR and I reviewed it 😄

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment through NewDot Manual Requests
  • @fedirjh requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hungvu193 / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
  • [@hungvu193 / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@hungvu193 / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@hungvu193 / @fedirjh] Determine if we should create a regression test for this bug.
  • [@hungvu193 / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@fedirjh
Copy link
Contributor

fedirjh commented Jul 10, 2024

requires payment through NewDot Manual Requests - please request $250 via ND.

@zanyrenney This one should be paid via Upwork as my assignment date precedes my eligibility date for newDot payment (2024-05-17)

@mountiny mountiny reopened this Jul 10, 2024
@mountiny
Copy link
Contributor Author

$250 to @fedirjh and $250 to @hungvu193

@mountiny mountiny added Daily KSv2 and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot added Overdue Weekly KSv2 and removed Daily KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd Jul 15, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment through NewDot Manual Requests
  • @fedirjh requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jul 15, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hungvu193 / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
  • [@hungvu193 / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@hungvu193 / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@hungvu193 / @fedirjh] Determine if we should create a regression test for this bug.
  • [@hungvu193 / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@hungvu193
Copy link
Contributor

Requested on ND

@JmillsExpensify
Copy link

$250 approved for @hungvu193

Copy link

melvin-bot bot commented Jul 22, 2024

Payment Summary

Upwork Job

BugZero Checklist (@zanyrenney)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1788566297116684288/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@JmillsExpensify
Copy link

$250 approved for @fedirjh

@zanyrenney
Copy link
Contributor

zanyrenney commented Jul 23, 2024

post is closed on upwork.
I don't think we need a regression test here because its related to the API

@zanyrenney
Copy link
Contributor

Payment Summary
Upwork Job

Reviewer: @hungvu193 owed $250 via NewDot - paid via ND see comment above
Reviewer: @fedirjh owed $250 via NewDot (please request via ND)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants