[QBO] App crashes when toggling on "Sync reimbursed reports"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.72-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers): applausetester+kh250402@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
logs Web.docx
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Account is connected to QBO,

1. Launch New Expensify app.
2. Log in to applausetester+kh250402@applause.expensifail.com
3. Go to Account settings > Workspaces > any workspace.
4. Go to Accounting.
5. Click Advanced.
6. Toggle on "Sync reimbursed reports".

Expected Result:

"Sync reimbursed reports" can be toggled on.

Actual Result:

App crashes.
On web, it shows console error.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6462640_1714124252111.web.mp4

Bug6462640_1714123895514.Android.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when toggling on "Sync reimbursed reports" .

What is the root cause of that problem?

The existing logic to pass settingValue fails when both qboAccountOptions and invoiceAccountCollectionOptions are empty since the first element would not exist. Also, if the first element is undefined/null, then .id would get called on that.

isSyncReimbursedSwitchOn ? '' : [...qboAccountOptions, ...invoiceAccountCollectionOptions][0].id,

What changes do you think we should make in order to solve the problem?

onToggle: () => {
    let firstId = null
    const combinedOptions = [...qboAccountOptions, ...invoiceAccountCollectionOptions].filter(option => option);

    if (combinedOptions.length > 0) {
        firstId = combinedOptions[0].id;
    }

    return Connections.updatePolicyConnectionConfig(
        policyID,
        CONST.POLICY.CONNECTIONS.NAME.QBO,
        CONST.QUICK_BOOKS_CONFIG.COLLECTION_ACCOUNT_ID,
        isSyncReimbursedSwitchOn ? '' : firstId,
    )
},

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[trjExpensify]

👋 @kbecciv can you share with us which Applause QBO account you used to connect here?

I tried the one under "Applause QBO" with applausetester+qbo@applause.expensifail.com in 1Password, and I can't reproduce it:

2024-05-14_23-33-18.mp4

[anmurali]

This is still being worked on, so not overdue.

[kavimuru]

Tester is still able to reproduce this issue.

Screen_Recording_20240516_003404_One.UI.Home.mp4

[trjExpensify]

^^ confirming if this is Android only or something in thread.

[trjExpensify]

Alrighty, turns out they weren't trying with a new connection and that explains why I wasn't able to reproduce it repeatedly using the same QBO account. Closing!