[HOLD for payment 2024-06-03] [QBO] Not all default settings & accounts are selected when establishing the connection to QBO

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.66-1
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714060188157459?thread_ts=1714057353.559839&cid=C036QM0SLJK & https://expensify.slack.com/archives/C036QM0SLJK/p1714091531288649?thread_ts=1713799261.297609&cid=C036QM0SLJK

Action Performed:

1. Connect to QBO
2. Go to Export
3. Observe not all settings are selected by default
4. Choose an export method for, say, company card export
5. Observe the account selection is not selected

Expected Result:

1. The following export settings should also be set by default when making a connection to QBO:

Export page

• Preferred exporter = [policyOwner]
• Date = Export date
• Export out of pocket expenses as =
  • Export as = Vendor bill
  • Accounts payable = [first applicable account in the list is selected] Note: This select list appears to be completely blank right now, let's fix that
• Export invoices as = [first applicable account in the list is selected]
• Export company cards as =
  • Export as = Credit card
  • Account = [first applicable account in the list is selected]

2. Then when choosing alternative export options, let's make sure the first applicable account in the list is selected as well:

"Export out of pocket expenses as" alt settings

• Export as = Journal entry

• Accounts payable = [first applicable account in the list is selected]

• Export as = Check

• Accounts payable = [first applicable account in the list is selected]

"Export company cards as" alt settings

• Export as = Debit card

• Account = [first applicable account in the list is selected]

• Export as = Vendor bill

• Accounts payable = [first applicable account in the list is selected]

• Default vendor (if enabled, disabled by default)

  • Vendor = [first applicable account in the list is selected]

3. Let's make sure we apply these changes on the "Advanced" page as well where applicable:

• Sync reimbursed reports (setting should be toggled on by default) =
  • QuickBooks bill payment account = [first applicable account in the list is selected]
  • QuickBooks invoice collections account = [first applicable account in the list is selected]

4. When someone changes a configuration setting (i.e updates exporting from Credit card to Vendor bill, make sure the value in the push input for the associated account selection is also updated along with the push label change. I.e

• Export as = Credit card

• Account = Amex Card Account

• Export as = Vendor bill

• Accounts payable = [first applicable account in the vendor list is selected]

Actual Result:

1. Only the value in the Preferred exporter list looks to be selected by default on the export settings page
2. When choosing an export method (i.e Credit Card) the first value in the sub-account that's revealed is not selected
3. Sync reimbursed reports is not enabled by default on the Advanced page, and the two associated accounts with that setting aren't selected by default either
4. Previously selected values are not cleared from the push input as the push label updates

Workaround:

Yes, they can select values and change values.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2024-04-26_01-51-56.mp4

View all open jobs on GitHub

CC: @hayata-suenaga @aldo-expensify @s77rt @teneeto @narefyev91 @zanyrenney

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[aldo-expensify]

I think here is the OldDot code choosing the default settings: https://github.com/Expensify/Web-Expensify/blob/52310ff233e1bca38dd0c3238336646c1c66e640/site/deprecated/lib_policy_quickbooksOnline.js#L370-L409

[aldo-expensify]

Created draft PR for the integration server to select the default values during the first import: https://github.com/Expensify/Integration-Server/pull/7882

[melvin-bot]

@trjExpensify, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Whoops! We need to assign Aldo here, he's actively working on PRs to address these. :)

[aldo-expensify]

For choosing the defaults, what I did is:

1. Connect a QBO to a policy in OldDot
2. The configuration modal opens automatically after.
3. Save the configuration modal without touching it

The configuration at this point is what I used as a reference for the default in the QBO flow from NewDot. Do you think that is correct?

[trjExpensify]

Okay, a few things just testing on staging with these changes:

1. None of the export settings have been set:

2. There's now some odd label name issue on the Date field in the export settings:

3. We aren't showing Chart of Accounts as Imported by default:

4. We've enabled Classes and Customers & Projects (which tbf, is like OldDot, so fine for now) but Tags isn't being added to the LHN of the workspace settings and I can't see them imported.

That might have something to do with the infinite spinner and currency crash I'm running into when establishing the connection.

[trjExpensify]

^^ working theory on the above is that this PR will fix them: #41155

[aldo-expensify]

Haven't investigated this again. no updates

[melvin-bot]

@trjExpensify, @s77rt, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

What's the plan? Wait for the other PRs to hit staging and re-test?

[aldo-expensify]

Can we retest this and summarize what is left to fix? I think some of the things mentioned in this issue must have been fixed, right?

[trjExpensify]

Sure!

1. Credit card Account is not being selected by default

2. Clicking the Account row navigates to a Default vendor page not Account page to select applicable credit card accounts:

(Same goes for if you switch to Debit card)

3. Selecting Vendor bill for company card export has Default vendor toggled on by default, when it shouldn't. The row is also bold for some reason?

Note: when you do toggle Default vendor the first vendor in the list of vendors should be selected

[melvin-bot]

@trjExpensify @s77rt @aldo-expensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[hayata-suenaga]

Selecting Vendor bill for company card export has Default vendor toggled on by default, when it shouldn't. The row is also bold for some reason?
Let me check on this. If this is a front end issue, I can handle it with the above PR. If this is not, I gonna ping Aldo. Otherwise, I'll handle these remaining issues myself so that Aldo can focus on the remaining QBO backend issue once he comes back from fixing the performance fire. 😄

I checked on this, and the value of config.autoCreateVendor is true when connected to accounting software. I think this is a backend issue.

[hayata-suenaga]

The default value is set to true in the Integration Server. I think we made a mistake in this PR for the default value of autoCreateVendor.

https://github.com/Expensify/Integration-Server/blob/6053b252a5c9d33b8e1d06b38d36f69f8b17df51/src/expensify/beans/expensify/policy/integration/quickbooksonline/QuickbooksOnlineConfiguration.java#L47

I'll make a PR to fix this.
-> Update: opened an integration server PR

[hayata-suenaga]

Once this PR hits production, I gonna test on staging to check if all default values are set correctly and then if it tests well, I'll close this issue

[trjExpensify]

Yep, sounds good. Would be good to know how close we are!

[hayata-suenaga]

the PR wasn't been deployed yet because of the freeze. I think the fire issue has been fixed, and once deployed, I'll test this 👍

[trjExpensify]

#42102 is deployed to staging.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix navigation and account selection on the accounting company card export page #42102

If no regressions arise, payment will be issued on 2024-06-03. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[hayata-suenaga]

tested well for me

test.1.mov

[hayata-suenaga]

We keep this issue open to handle the payment for @s77tr for this App PR.

[s77rt]

• The PR that introduced the bug has been identified: I think this existed from the start. I found this PR Fix QBO config types + fix inputs in config pages #41463 that changed the navigation logic but not the real culprit
• The offending PR has been commented on: n/a
• A discussion in #expensify-bugs has been started: n/a
• Determine if we should create a regression test for this bug: No

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

Payment summary as follows:

• $250 to @s77rt for the C+ review

Offer sent!

[s77rt]

@trjExpensify Accepted! Thanks!

[trjExpensify]

Paid. Closing!