[$250] Android - Chat - Emoji keyboard can not be activated when no other character is added in chat box

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gatantm@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

The issue was detected on the following devices: Google Pixel 8 - Android 14, Google Pixel 6 - Android 14.

1. Launch the app and go to any chat/report
2. Using Gboard keyboard try to use the emoji keyboard without adding anything else in the text box

Expected Result:

The native emoji keyboard is shown at any flow without issues

Actual Result:

The native emoji keyboard is not shown if there's no other character already entered on the text field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6461786_1714061290310.az_recorder_20240425_190214.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f981538723950232
• Upwork Job ID: 1783601692500316160
• Last Price Increase: 2024-05-09

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

Production:

az_recorder_20240425_210141.mp4

[tylerkaraszewski]

I think we can add external to this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f981538723950232

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[seanbashaw]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The emoji keyboard on android doesn't work unless there's already text in the box.

What is the root cause of that problem?

Inside of the ComposerWithSuggestions.tsx file there is a boolean to detect if the current platform is an IOS native.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 184 in 951c7b3

const isIOSNative = getPlatform() === CONST.PLATFORM.IOS;

However, there is no boolean currently set to detect if the platform is an Android native. This IOS Native boolean alone is used in further logic that should incorporate Android natives as well.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 427 in 951c7b3

if (isIOSNative) {

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 551 in 951c7b3

if (isIOSNative && syncSelectionWithOnChangeTextRef.current) {

After a more complete examination I believe the result is from b107b9c, which includes changes to IOS that should also extend to Android.

What changes do you think we should make in order to solve the problem?

Adding an additional variable for android OS and incorporating it into the logic will solve the issue and check

What alternative solutions did you explore? (Optional)

I used my skills to trace the problem directly from the problem description and video. The "Write Something..." prompt led me to the reportActionCompose.writeSomething variable which, after filtering out other avenues, led me to this viable solution.

[melvin-bot]

📣 @seanbashaw! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[seanbashaw]

Contributor details
Your Expensify account email: seanbshw@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01f678064fae0b9928

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[mountiny]

I am demoting this from being blocker as there is a workaround of posting some character or using the in-product emoji keyboard, also this seems to be repro only on some specific Android devices.

@seanbashaw thanks for the proposal. The changes you have linked are very old, but this seems to not be repro in production. Would you be able to highlight what change in recent release could have caused this regression?

[mountiny]

Posted here for help

[seanbashaw]

@mountiny This logic still exist in the most recent version. The following function onChangeText shows this logic being implemented still.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 547 to 564 in 10fc359

	const onChangeText = useCallback(
	(commentValue: string) => {
	updateComment(commentValue, true);
	if (isIOSNative && syncSelectionWithOnChangeTextRef.current) {
	const positionSnapshot = syncSelectionWithOnChangeTextRef.current.position;
	syncSelectionWithOnChangeTextRef.current = null;
	// ensure that selection is set imperatively after all state changes are effective
	InteractionManager.runAfterInteractions(() => {
	// note: this implementation is only available on non-web RN, thus the wrapping
	// 'if' block contains a redundant (since the ref is only used on iOS) platform check
	textInputRef.current?.setSelection(positionSnapshot, positionSnapshot);
	});
	}
	},
	[updateComment],
	);

The following commit shows functionality being removed that could have been covered for android in a file that has since been renamed.
b2ff88c

[melvin-bot]

@tylerkaraszewski, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@tylerkaraszewski, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[tylerkaraszewski]

Doesn't seem like we do.

[shubham1206agra]

@tylerkaraszewski Can we either raise the bounty of this issue or call someone from expert group?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@tylerkaraszewski, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@tylerkaraszewski, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@tylerkaraszewski, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[tylerkaraszewski]

Closing because not reproducible.