Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding - Onboarding video does not have an audio #41000

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 25, 2024 · 21 comments
Closed
1 of 6 tasks

Onboarding - Onboarding video does not have an audio #41000

lanitochka17 opened this issue Apr 25, 2024 · 21 comments
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #40688

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Sign in with a new Gmail account
  3. On the Onboarding select "Track business spend for taxes" as a purpose and click on continue
  4. Input first name and last name and click on continue
  5. Input a business name and click on continue
  6. When the Welcome to Expensify modal opens up click on the unmute button to check the audio and notice it works fine
  7. Open Concierge chat and wait for the backend to send attachment
  8. Once the attachment loads play the video and unmute it

Expected Result:

Audio works fine and can be heard

Actual Result:

There is no audio for the video

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6461727_1714058331742.bandicam_2024-04-25_18-15-16-011.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@mountiny mountiny assigned mountiny and unassigned jasperhuangg Apr 26, 2024
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 26, 2024
@mountiny
Copy link
Contributor

This is a new feature so not a blocker, discussing here if the videos should have sounds, I did not have the sounds when testing it before

@mountiny
Copy link
Contributor

this is expected now, not a problem with the videos

@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

@mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor

I believe @dubielzyk-expensify Will handle this one, assigning and making weekly

@dubielzyk-expensify
Copy link
Contributor

I'll get this done. Basically just need TCW to export new videos with songs. It's not a huge priority, but I'll update once I've done it

@dubielzyk-expensify
Copy link
Contributor

Update: Asked TCW for them but mentioned it was low priority, but will let y'all know when we get the final files

@dubielzyk-expensify
Copy link
Contributor

We have the final videos here now with video, but I would require help in compressing and replacing them. Last time we got @francoisl 's help, so I'd love to get his help again 😇

@francoisl
Copy link
Contributor

Yeah I can help. Can you double-check that Dropbox URL and make sure I have read access to it please? I'm getting a The folder ‘Expensify/Design/Product GIFs/01_MP4’ doesn’t exist. error.

@dubielzyk-expensify
Copy link
Contributor

No idea why this happens. Thought everyone had access to it. Shared with you directly regardless 😄

@francoisl
Copy link
Contributor

Sorry @dubielzyk-expensify the link https://www.dropbox.com/home/Expensify/Design/Product%20GIFs/01_MP4 still doesn't work, however I can access https://www.dropbox.com/home/01_MP4. To confirm, the new videos we need to compress are the ones whose name ends with -sound.mp4, right?

@dubielzyk-expensify
Copy link
Contributor

dubielzyk-expensify commented May 10, 2024

To confirm, the new videos we need to compress are the ones whose name ends with -sound.mp4, right?

Correct.

No idea why this happens. cc @Expensify/design

@dannymcclain
Copy link
Contributor

Dang no idea on that either. The permissions for that folder (and all the ones above it) look correct? That's odd.

@shawnborton
Copy link
Contributor

No idea either... we should totally ditch Dropbox for Drive at some point but that's a different conversation.

@shawnborton
Copy link
Contributor

But yeah, in the meantime, maybe we put these on Drive for Francois or something.

@francoisl
Copy link
Contributor

No worries, I'm still able to see the new videos. Thanks guys!

I'll send a PR shortly to use the new videos. I also wrote the command I use to rescale videos in Stackoverflow https://stackoverflowteams.com/c/expensify/questions/19224/19225#19225

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 10, 2024
@mountiny
Copy link
Contributor

PR approved, waiting for design feedback about the default sound settings

@dubielzyk-expensify
Copy link
Contributor

We've left sound off by default, but I believe that PR has been merged, so are we good to close this one?

@mountiny
Copy link
Contributor

yeah, nothing to pay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants