-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding - Onboarding video does not have an audio #41000
Comments
Triggered auto assignment to @jasperhuangg ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
This is a new feature so not a blocker, discussing here if the videos should have sounds, I did not have the sounds when testing it before |
this is expected now, not a problem with the videos |
@mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I believe @dubielzyk-expensify Will handle this one, assigning and making weekly |
I'll get this done. Basically just need TCW to export new videos with songs. It's not a huge priority, but I'll update once I've done it |
Update: Asked TCW for them but mentioned it was low priority, but will let y'all know when we get the final files |
We have the final videos here now with video, but I would require help in compressing and replacing them. Last time we got @francoisl 's help, so I'd love to get his help again 😇 |
Yeah I can help. Can you double-check that Dropbox URL and make sure I have read access to it please? I'm getting a |
No idea why this happens. Thought everyone had access to it. Shared with you directly regardless 😄 |
Sorry @dubielzyk-expensify the link https://www.dropbox.com/home/Expensify/Design/Product%20GIFs/01_MP4 still doesn't work, however I can access https://www.dropbox.com/home/01_MP4. To confirm, the new videos we need to compress are the ones whose name ends with |
Correct. No idea why this happens. cc @Expensify/design |
Dang no idea on that either. The permissions for that folder (and all the ones above it) look correct? That's odd. |
No idea either... we should totally ditch Dropbox for Drive at some point but that's a different conversation. |
But yeah, in the meantime, maybe we put these on Drive for Francois or something. |
No worries, I'm still able to see the new videos. Thanks guys! I'll send a PR shortly to use the new videos. I also wrote the command I use to rescale videos in Stackoverflow https://stackoverflowteams.com/c/expensify/questions/19224/19225#19225 |
PR approved, waiting for design feedback about the default sound settings |
We've left sound off by default, but I believe that PR has been merged, so are we good to close this one? |
yeah, nothing to pay |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #40688
Action Performed:
Expected Result:
Audio works fine and can be heard
Actual Result:
There is no audio for the video
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6461727_1714058331742.bandicam_2024-04-25_18-15-16-011.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: