Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Payment due][$500] Implement Uneven Splits #40616

Closed
youssef-lr opened this issue Apr 19, 2024 · 24 comments
Closed

[Payment due][$500] Implement Uneven Splits #40616

youssef-lr opened this issue Apr 19, 2024 · 24 comments
Assignees
@youssef-lr @kadiealexander
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Task

Comments

@youssef-lr
Copy link
Contributor

youssef-lr commented Apr 19, 2024 •
edited by kadiealexander
Loading

Implement this section of the design doc.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012b261d8e3721b659
  • Upwork Job ID: 1794886821581795328
  • Last Price Increase: 2024-05-27
Issue OwnerCurrent Issue Owner: @kadiealexander
@youssef-lr youssef-lr self-assigned this Apr 19, 2024
@youssef-lr youssef-lr mentioned this issue Apr 19, 2024
Merged
59 tasks
@youssef-lr
Copy link
Contributor Author

PR should be ready for review first thing Monday morning.

@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@youssef-lr
Copy link
Contributor Author

More progress is done in the PR, I'm resolving one final issue here

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Apr 22, 2024
@youssef-lr youssef-lr changed the title Implement Uneven Splits [$500] Implement Uneven Splits Apr 22, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 22, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@youssef-lr
Copy link
Contributor Author

Heads up: C+ payout for this one should be $500.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 7, 2024
@melvin-bot Melvin Bot

This comment was marked as outdated.

Sign in to view
@melvin-bot Melvin Bot

This comment was marked as outdated.

Sign in to view
@melvin-bot Melvin Bot

This comment was marked as off-topic.

Sign in to view
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@youssef-lr
Copy link
Contributor Author

This is done!

@c3024
Copy link
Contributor

c3024 commented May 18, 2024 •
edited
Loading

@youssef-lr I was the C+ for the PR and reviewed and tested it. Could you please reopen this for payment?

@youssef-lr youssef-lr reopened this May 18, 2024
@youssef-lr
Copy link
Contributor Author

Done, sorry!

@c3024
Copy link
Contributor

c3024 commented May 18, 2024

Thanks. I think Bug and Daily labels need to be added for assigning a BZ member for payment.

@youssef-lr
Copy link
Contributor Author

Will do on Monday.

@c3024
Copy link
Contributor

c3024 commented May 22, 2024

@youssef-lr gentle bump on this

@youssef-lr youssef-lr added the Bug Something is broken. Auto assigns a BugZero manager. label May 22, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 22, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 22, 2024
@youssef-lr
Copy link
Contributor Author

@kadiealexander can we please issue payment for @c3024? Thanks!

@kadiealexander kadiealexander added the External Added to denote the issue can be worked on by a contributor label May 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012b261d8e3721b659

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 27, 2024
@kadiealexander kadiealexander removed the External Added to denote the issue can be worked on by a contributor label May 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

@kadiealexander
Copy link
Contributor

@c3024 could you please apply in Upwork here? Thanks!

@kadiealexander kadiealexander changed the title [$500] Implement Uneven Splits [Payment due][$500] Implement Uneven Splits May 27, 2024
@c3024
Copy link
Contributor

c3024 commented May 27, 2024

@kadiealexander applied, thanks. But the Upwork job price is shown as only $250. This is a $500 issue.

@kadiealexander
Copy link
Contributor

Fixed.

@c3024
Copy link
Contributor

c3024 commented May 27, 2024

Applied!

@kadiealexander
Copy link
Contributor

kadiealexander commented May 27, 2024 •
edited
Loading

Payouts due:

Upwork job is here.

@c3024
Copy link
Contributor

c3024 commented May 27, 2024

Thanks, accepted the offer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youssef-lr youssef-lr

@kadiealexander kadiealexander

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@youssef-lr @shubham1206agra @kadiealexander @c3024