[$250] Hold request - Duplicate expense info shown if partially approving report with on hold expense

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-5
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #40065
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

recondition: user is an admin of collect workspace and invites an employee

1. Go to https://staging.new.expensify.com/
   and log in as employee
2. Open the workspace chat and create 2 expense
3. Submit the report
4. Log in to ND as admin
5. Navigate the workspace chat
6. Open the submitted report and put on hold one of the expenses
7. Partially approve report (only the expense that is not on hold)
8. After the expense that is on hold is moved to a new report, open it

Expected Result:

The expense is still on hold, no duplicated info is shown

Actual Result:

The "On hold" badge is removed, the duplicated expense info is displayed for both admin and employee. Also, the "Hmm, not here.." screen is displayed after partially approving the report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6454440_1713496120230.Recording__422.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014c7c1c7bfdf30f7a
• Upwork Job ID: 1781783652002193408
• Last Price Increase: 2024-04-20

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@abekkala I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

bandicam.2024-04-19.08-01-29-650.mp4

[thienlnam]

cc @robertjchen Related to hold

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014c7c1c7bfdf30f7a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[mountiny]

cc @marcochavezf from the PR

[marcochavezf]

Yeah, seems this is the same issue from this internal convo

[mountiny]

If that is the case, I believe this is a backend issue and we can remove the blocker label, thanks

[melvin-bot]

@marcochavezf, @abekkala, @Gonals, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

@mountiny does this need a backend fix completely? If so, I can adjust the labels accordingly.
OR, does this first need a backend (internal fix) then move onto an external

[marcochavezf]

The fix needed was backend completely and has been deployed to production. Closing it