Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-09] Stop sending <mention-report> when not in a policy room #40480

Closed
rlinoz opened this issue Apr 18, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@rlinoz
Copy link
Contributor

rlinoz commented Apr 18, 2024

When we add a comment to a report we parse it before sending to the backend with ExpensiMark here.

We added the logic to parse #room-name to <mention-report>#room-name</mention-report> here, but since we only allow report mentions to happen inside policy rooms, we should prevent the parsing from happening for messages sent outside of a policy room.

Issue OwnerCurrent Issue Owner: @greg-schroeder
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013f795318d2531edc
  • Upwork Job ID: 1787964711355367424
  • Last Price Increase: 2024-05-07
@robertKozik
Copy link
Contributor

Hi, can you assign me to this issue?

@robertKozik
Copy link
Contributor

PR for parser is ready

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 23, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 2, 2024
@melvin-bot melvin-bot bot changed the title Stop sending <mention-report> when not in a policy room [HOLD for payment 2024-05-09] Stop sending <mention-report> when not in a policy room May 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 2, 2024
Copy link

melvin-bot bot commented May 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-09. 🎊

For reference, here are some details about the assignees on this issue:

@rlinoz rlinoz added the Bug Something is broken. Auto assigns a BugZero manager. label May 2, 2024
Copy link

melvin-bot bot commented May 2, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 2, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented May 2, 2024

@greg-schroeder, @ahmedGaber93 was the PR reviewer.

@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
@greg-schroeder
Copy link
Contributor

Okay got it - set for payment on 5/9

@melvin-bot melvin-bot bot removed the Overdue label May 7, 2024
@greg-schroeder
Copy link
Contributor

Going to add Internal label just to create an upwork job

@greg-schroeder greg-schroeder added the Internal Requires API changes or must be handled by Expensify staff label May 7, 2024
Copy link

melvin-bot bot commented May 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013f795318d2531edc

Copy link

melvin-bot bot commented May 7, 2024

Current assignee @ahmedGaber93 is eligible for the Internal assigner, not assigning anyone new.

@greg-schroeder
Copy link
Contributor

Offer sent to @ahmedGaber93 ahead of 5/9 payment date

@ahmedGaber93
Copy link
Contributor

@greg-schroeder offer is accepted, Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels May 8, 2024
@greg-schroeder
Copy link
Contributor

paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

4 participants