-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-09] Stop sending <mention-report> when not in a policy room #40480
Comments
Hi, can you assign me to this issue? |
PR for parser is ready |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-09. 🎊 For reference, here are some details about the assignees on this issue:
|
Triggered auto assignment to @greg-schroeder ( |
@greg-schroeder, @ahmedGaber93 was the PR reviewer. |
Okay got it - set for payment on 5/9 |
Going to add |
Job added to Upwork: https://www.upwork.com/jobs/~013f795318d2531edc |
Current assignee @ahmedGaber93 is eligible for the Internal assigner, not assigning anyone new. |
Offer sent to @ahmedGaber93 ahead of 5/9 payment date |
@greg-schroeder offer is accepted, Thanks! |
paid |
When we add a comment to a report we parse it before sending to the backend with
ExpensiMark
here.We added the logic to parse
#room-name
to<mention-report>#room-name</mention-report>
here, but since we only allow report mentions to happen inside policy rooms, we should prevent the parsing from happening for messages sent outside of a policy room.Issue Owner
Current Issue Owner: @greg-schroederUpwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: