[$250] Group chat - User can return to group chat after leaving the group chat via back button

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to FAB > Start chat.
3. Create a group chat.
4. Tap on the chat header.
5. Tap Leave.
6. Tap on the back button twice.

Expected Result:

App will not return to the group chat after user leaves the group.

Actual Result:

App returns to the group chat which is now flickering in iOS
Skeleton view in Android
hmm it is not there page in web

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453676_1713449035829.RPReplay_Final1713448827.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fa7d2f8d25655a13
• Upwork Job ID: 1781033856171855872
• Last Price Increase: 2024-04-18
• Automatic offers:
• Ollyws | Reviewer | 0
• neonbhai | Contributor | 0
• eh2077 | Contributor | 0

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #vip-vsb

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group chat - User can return to group chat after leaving the group chat via back button

What is the root cause of that problem?

When navigating away from the group chat using navigateToMostRecentReport, we don't replace the last page from navigation history, allowing us to return on pressing back

App/src/libs/actions/Report.ts

Line 2424 in 168ce62

Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID ?? ''));

and

App/src/libs/actions/Report.ts

Line 2433 in 168ce62

Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat?.reportID));

What changes do you think we should make in order to solve the problem?

We should pass CONST.NAVIGATION.TYPE.UP as the second param when navigating away in navigateToMostRecentReport

Note: navigateToMostRecentReport is called only leaveGroup and leaveRoom so navigation type need not be enabled by a prop

Alternatively

We may pass CONST.NAVIGATION.TYPE.FORCED_UP as the navigation type

[marcaaron]

Hmm this one looks bad and seems like a good Deploy Blocker. @thienlnam I can take this from you.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fa7d2f8d25655a13

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[marcaaron]

@neonbhai solution makes sense to me. Can you get something up soon? Feel free to combine the change from #40470 into one PR so we can CP it when ready.

[laurenreidexpensify]

Just to confirm - this was the PR right, #40563, and that went to prod on 22 April, so this is due for payment today 29 April? cc @marcaaron @neonbhai @Ollyws

[neonbhai]

@laurenreidexpensify yes, the PR was combined with another PR to get it CP'ed quick. And you're right, it is due for payment today

[Ollyws]

I didn't review this one though so no payment required for me.

[marcaaron]

It was reviewed by @eh2077 however so I'll add them here.

[melvin-bot]

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[laurenreidexpensify]

Payment Summary:

• Contributor $250 @neonbhai paid in Upwork
• C+ $250 @eh2077 paid in Upwork

[laurenreidexpensify]

Apols for the delay here folks! Everyone is paid now

[laurenreidexpensify]

No regression test as caught by internal applause team, closing