[$250] iOS - Chat - Inconsistency in sending attachments offline when you come back online.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4488629
Email or phone of affected tester (no customers): vdargentotest+ios041024@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team

Action Performed:

Pre-requisite: the user must be logged in.

1. Go to any chat.
2. Disable the internet connection.
3. Send an image.
4. Verify "Uploading attachment..." message appears and is grayed out.
5. Kill the app.
6. Enable the internet connection.
7. Open the app and go to the same chat.
8. Verify "Uploading attachment..." message is no longer grayed out, but the attachment is never sent.
9. Send another attachment.
10. Verify the last attachment is sent but the rest of the chat is replaced by a loading skeleton and is no longer accessible.

Expected Result:

When coming back online and reopening the app, the attachment should be sent.

Actual Result:

The attachment sent while offline is not sent after re-opening app when back online. Also, if another attachment is sent, the rest of the chat is replaced by a loading skeleton.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6445168_1712786306412.Bboj3163_1_.mp4

Bug6445168_1712826823391!Profile_trace_for_1.4.62-0.cpuprofile

Bug6445168_1712826851957!logs-2024-04-11_09_10_59.286.txt
Bug6445168_1712826841139!App_Info_1.4.62-0.json

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013405544bf82d5dde
• Upwork Job ID: 1781363043681558528
• Last Price Increase: 2024-04-19

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@twisterdotcom I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

RPReplay_Final1712824946.MP4

[twisterdotcom]

I don't think this is an issue right? Here's my recreation where it did upload when I came back online:

RPReplay_Final1712830562.MP4

Going to remove as a blocker and close.

[kbecciv]

Reopening the issue for second chance, QA team is able to reproduce it on build 1.4.63.0

Ekse6944.1.mp4

[twisterdotcom]

Okay I see this now. I think we basically need to have better error messaging around when a file is completely dropped from uploading or fails uploading.

40093.mp4

[twisterdotcom]

Slack is really good at this actually:

RPReplay_Final1713544638.MP4

[twisterdotcom]

Gonna go external, but maybe this could be internal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[melvin-bot]

@twisterdotcom, @MonilBhavsar, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[twisterdotcom]

@MonilBhavsar or @shubham1206agra at the least, I'd be intrigued for your take on External or Internal here.

[shubham1206agra]

@twisterdotcom I think BE should send an error if no file is present while uploading an attachment.

[MonilBhavsar]

Curious then why it only happens for iOS

[melvin-bot]

@twisterdotcom @MonilBhavsar @shubham1206agra this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[twisterdotcom]

Okay, gonna make it Internal and VSB for now. But, pretty low stakes atm.

[melvin-bot]

Current assignee @shubham1206agra is eligible for the Internal assigner, not assigning anyone new.

[twisterdotcom]

Still very low. Not even assigned a status yet.

[twisterdotcom]

At this point, I think we can punt.