Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHN - LHN displayed blank for a 1-2 second when user rapidly scrolled up #39849

Closed
3 of 6 tasks
kbecciv opened this issue Apr 8, 2024 · 6 comments
Closed
3 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Apr 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: user should be signed in

  1. Open app
  2. Scroll down to the very bottom
  3. Rapidly scroll up to the very top

Expected Result:

LHN should be properly displayed during scrolling

Actual Result:

LHN displayed blank for a 1-2 second when user rapidly scrolled up

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442317_1712583361025.RPReplay_Final1712583323.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny
Copy link
Contributor

mountiny commented Apr 8, 2024

I dont think this is a blocker, this has been happening for a while, it just might be more visible on some devices than others

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 8, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 8, 2024

Its just a nature of the FlashList, only some of the rows are rendered for performance reasons so when user scrolls so fast the top rows will not be rendered yet.

@mountiny
Copy link
Contributor

mountiny commented Apr 8, 2024

I believe we can close this

@roryabraham
Copy link
Contributor

yeah, this is just a performance issue. Let's close this for now, but in the next performance audit maybe we can try to introduce a "scroll drop" metric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants