Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting Payment 16th May] [Wave Collect] [Xero] [Advanced] Create the main Advanced Settings page #39746

Closed
lakchote opened this issue Apr 5, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@lakchote
Copy link
Contributor

lakchote commented Apr 5, 2024

You need to build the page following the steps outlined here.

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

@lakchote lakchote added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 5, 2024
@lakchote lakchote moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
@Christinadobrzyn
Copy link
Contributor

@lakchote are you working on this too? looks like there's no engineer assigned yet so just checking

@lakchote lakchote self-assigned this Apr 11, 2024
@lakchote
Copy link
Contributor Author

@lakchote are you working on this too? looks like there's no engineer assigned yet so just checking

Yes, I'll be working on this.

@lakchote lakchote changed the title [Wave Collect] [Xero] [Advanced] Create the main Advanced Settings page [HOLD #39725] [Wave Collect] [Xero] [Advanced] Create the main Advanced Settings page Apr 15, 2024
@lakchote
Copy link
Contributor Author

Updated title with the HOLD issue.

@trjExpensify trjExpensify moved this from Release 1: Spring 2024 (May) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect Apr 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 23, 2024
@Christinadobrzyn
Copy link
Contributor

we're on hold for this - #39725 right @lakchote?

@melvin-bot melvin-bot bot removed the Overdue label Apr 26, 2024
@lakchote lakchote changed the title [HOLD #39725] [Wave Collect] [Xero] [Advanced] Create the main Advanced Settings page [Wave Collect] [Xero] [Advanced] Create the main Advanced Settings page Apr 30, 2024
@lakchote
Copy link
Contributor Author

we're on hold for this - #39725 right @lakchote?

Yes, we were on hold for #39725 to be merged.

It was merged yesterday. Technically we are able to work on this now.

I'm going to focus today on fixing the remaining bugs for the Xero authorization flow before working on it.

@rushatgabhane
Copy link
Member

I'm working on this

@Christinadobrzyn
Copy link
Contributor

awesome! thank you @rushatgabhane added you to the GH - we'll monitor the PR #41475

@trjExpensify
Copy link
Contributor

Deployed to production 9 hours ago.

@trjExpensify trjExpensify changed the title [Wave Collect] [Xero] [Advanced] Create the main Advanced Settings page [Awaiting Payment 16th May] [Wave Collect] [Xero] [Advanced] Create the main Advanced Settings page May 9, 2024
@trjExpensify trjExpensify added the Awaiting Payment Auto-added when associated PR is deployed to production label May 9, 2024
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented May 14, 2024

Payouts due—Based on our payment structure, I think this should be $500 since it relates to the roadmap? Do you think?

@rushatgabhane Do we need a regression test for this?

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 15, 2024
@Christinadobrzyn
Copy link
Contributor

nudge @rushatgabhane about a regression test for this. Maybe we can use the test steps in the PR for a regression test?

  • Navigate to a workspace with xero connected
  • Click advanced
  • Verify that you can see auto sync toggle. Verify that you can toggle it
  • Verify that there is a purchase bill status selector
  • Toggle reimbursed reports
  • Verify that toggling reimbursed reports shows/hides account selectors.

@trjExpensify
Copy link
Contributor

Payment will be handled centrally when we wrap the project, we can close this as the regression period is over.

Equally, we can hand over the regression tests to Applause once the project wraps (CC: @zanyrenney). Closing it out!

@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants