[HOLD for payment 2024-04-05] [Simplified Collect][Workflows] "Make or track payments" section is no longer grayed out after updating to USD

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when executing PR : #38318

Version Number: 1.4.56-1
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is admin of Collect workspace.
• The default currency for Collect workspace is not USD.
• Make or track payments in Workflows are disabled.

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Workflows.
4. Go offline.
5. Toggle on "Make or track payments".
6. Click Connect bank account > Update to USD.
7. Close bank account RHP.

Expected Result:

"Make or track payments" section will remain grayed out.

Actual Result:

"Make or track payments" section is no longer grayed out after selecting Update to USD.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6425351_1711311791044.20240325_035636.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012180f5608246c8c6
• Upwork Job ID: 1772232177098358784
• Last Price Increase: 2024-03-25
• Automatic offers:
• dukenv0307 | Reviewer | 0
• tienifr | Contributor | 0

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@trjExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #wave-control.

[izarutskaya]

Production different behavior

20240325_035944.mp4

[mountiny]

Nto a blocker, related to Simplified collect so happy to take over from Alex

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012180f5608246c8c6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[mountiny]

This can be external, its a simple polish item though so making it $250

[Krishna2323]

Will be fixed here.

[luacmartins]

@Krishna2323 I'm not sure how the PR you linked above fixes this issue.

[luacmartins]

I like @tienifr's proposal better since it's simpler (doesn't add any new pending fields) and keeps all existing pending fields. Assigning you to the job!

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@luacmartins, the solution by @tienifr is already implemented in this PR. I think we should hold. @tienifr, can you pls check if I'm wrong here. Thanks

[luacmartins]

Ah I see! Thanks for pointing that out! Gonna add this issue to the list of fixed issues of that PR.

[luacmartins]

Note: we can close this issue once the PR is deployed, since payment will be handled in #37254

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Workspace - If title is changed offline, the description is no Ionger greyed out. #38249

If no regressions arise, payment will be issued on 2024-04-05. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins / @mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins / @mountiny] Determine if we should create a regression test for this bug.
• [@luacmartins / @mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

payments will be handled here #37254

We can close this one