Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] [TS migration] Migrate IOURequestStartPage, IOURequestRedirectToStartPage, IOURequestStepDistance and IOURequestStepAmount pages to TypeScript #38914

Closed
fabioh8010 opened this issue Mar 25, 2024 · 23 comments
Closed

[$250] [TS migration] Migrate IOURequestStartPage, IOURequestRedirectToStartPage, IOURequestStepDistance and IOURequestStepAmount pages to TypeScript #38914

fabioh8010 opened this issue Mar 25, 2024 · 23 comments
Assignees
@luacmartins @joekaufmanexpensify @cdOut @ishpaul777
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Typescript Migration Weekly KSv2

Comments

@fabioh8010
Copy link
Contributor

fabioh8010 commented Mar 25, 2024 •
edited by melvin-bot bot
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

  • src/pages/iou/request/IOURequestStartPage.js
  • src/pages/iou/request/IOURequestRedirectToStartPage.js
  • src/pages/iou/request/step/IOURequestStepDistance.js
  • src/pages/iou/request/step/IOURequestStepAmount.js
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014c348bf4c4c3354b
  • Upwork Job ID: 1787477553272143872
  • Last Price Increase: 2024-05-06
Issue OwnerCurrent Issue Owner: @
@fabioh8010 fabioh8010 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 25, 2024
@fabioh8010
Copy link
Contributor Author

This issue is internal and will be handled by the TS team.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 25, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@joekaufmanexpensify
Copy link
Contributor

@fabioh8010 are you working on this yourself, or is the assignee TBD?

@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Daily KSv2 labels Mar 25, 2024
@fabioh8010
Copy link
Contributor Author

@joekaufmanexpensify Someone from the TS team will pick this issue shortly!

@joekaufmanexpensify
Copy link
Contributor

Got it. TY!

@joekaufmanexpensify joekaufmanexpensify added Monthly KSv2 and removed Weekly KSv2 labels Mar 25, 2024
@cdOut
Copy link
Contributor

cdOut commented Mar 26, 2024

Hi! I'm Tymek from Software Mansion, the expert agency, and I'd like to work on this issue.

@cdOut cdOut mentioned this issue Mar 28, 2024
Closed
50 tasks
@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Monthly KSv2 labels Apr 1, 2024
@joekaufmanexpensify
Copy link
Contributor

@cdOut is there an ETA for when a PR will be up here?

@cdOut
Copy link
Contributor

cdOut commented Apr 2, 2024

Yes, I should be done with it by today and hopefully we can push with reviews through tomorrow

@joekaufmanexpensify
Copy link
Contributor

@cdOut is the PR now in review? If so, mind linking it here?

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 8, 2024

@joekaufmanexpensify @cdOut this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@cdOut
Copy link
Contributor

cdOut commented Apr 9, 2024

I've pushed the recent changes into the linked PR, we will review internally and push for cross review ASAP.

@kosmydel kosmydel mentioned this issue Apr 9, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 9, 2024
@luacmartins luacmartins self-assigned this Apr 11, 2024
@ishpaul777
Copy link
Contributor

@luacmartins Can you please assign me here

@joekaufmanexpensify
Copy link
Contributor

PR awaiting deploy to staging

@joekaufmanexpensify
Copy link
Contributor

PR on staging

@ishpaul777
Copy link
Contributor

@joekaufmanexpensify Gentle bump for payment

@joekaufmanexpensify
Copy link
Contributor

Ah, looks like automation did not work.

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label May 6, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 6, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014c348bf4c4c3354b

@melvin-bot melvin-bot bot changed the title [TS migration] Migrate IOURequestStartPage, IOURequestRedirectToStartPage, IOURequestStepDistance and IOURequestStepAmount pages to TypeScript [$250] [TS migration] Migrate IOURequestStartPage, IOURequestRedirectToStartPage, IOURequestStepDistance and IOURequestStepAmount pages to TypeScript May 6, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 6, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 6, 2024

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 6, 2024
@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels May 6, 2024
@joekaufmanexpensify
Copy link
Contributor

Only payment needed here is $250 to @ishpaul777 for C+ review via upwork

@joekaufmanexpensify
Copy link
Contributor

@ishpaul777 offer sent!

@joekaufmanexpensify
Copy link
Contributor

@ishpaul777 $250 sent and contract ended

@joekaufmanexpensify
Copy link
Contributor

upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@joekaufmanexpensify joekaufmanexpensify

@cdOut cdOut

@ishpaul777 ishpaul777

Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Typescript Migration Weekly KSv2
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabioh8010 @luacmartins @mountiny @joekaufmanexpensify @cdOut @ishpaul777