[HOLD for payment 2024-07-10] [$500] IOU - Missing avatars and names above IOU preview in main chat after login

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.55-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4439905
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User A and B have no prior chat with each other
• User B must be logged out

1. Go to staging.new.expensify.com
2. [User A] Request money from User B
3. [User B] Log in
4. [User B] Open 1:1 DM with User A from LHN (or search if it does not show up in LHN)

Expected Result:

The IOU preview in the main chat will show user avatars and names

Actual Result:

The IOU preview in the main chat is missing user avatars and names. It only shows after opening IOU report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6420908_1710960400835.bandicam_2024-03-21_02-41-49-943.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b0f8b90c833a05f3
• Upwork Job ID: 1771271857156587520
• Last Price Increase: 2024-05-10
• Automatic offers:
• nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @adelekennedy

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@yuwenmemon FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[zanyrenney]

added to wave collect.

[zanyrenney]

Just a note to say, I am OOO now until April 2nd, reassigning BZ team member to help while I am OOO.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[adelekennedy]

@yuwenmemon it looks like the deploy blocker label was added by accident - I'm going to remove you and make this external (this seems like a FE issue to me at first glance - please let me know if you disagree!)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b0f8b90c833a05f3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[youssef-lr]

I have just merged the 2nd backend PR, once deployed we should have childOwnerAccountID as well

[nkdengineer]

Thanks.

[melvin-bot]

@eVoloshchak, @youssef-lr, @adelekennedy, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[eVoloshchak]

Not overdue, waiting for the backend PR to be deployed

[youssef-lr]

backend PR is currently in staging and should hit production soon, @nkdengineer you can ping the C+ for a review of the App PR

[nkdengineer]

@eVoloshchak The PR is here cc @youssef-lr.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: missing avatars and names above IOU preview in main chat after login  #42453

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that introduced this bug, this is a limitation of the initial implementation
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is a simple visual bug, I don't think additional discussion is needed

Regression Test Proposal

Preconditions:

1. User A and User B have no prior chat with each other
2. User B must be logged out

Regression test:

1. [User A] Request money from User B
2. [User B] Pay this money request
3. [User A] Clear cache and restart (or logout and login again)
4. [User A] Open the DM chat with user B without opening the iou report
5. [User A] Verify that both user's avatars are displayed for the money request

Do we agree 👍 or 👎

[adelekennedy]

I missed payment on this one, I'm so sorry! Taking care of it right now

[adelekennedy]

Payouts due:

• Contributor: $500 @nkdengineer (Upwork)
• Contributor+: $500 @eVoloshchak (NewDot)

Upwork job is here.

[adelekennedy]

https://github.com/Expensify/Expensify/issues/413250

[JmillsExpensify]

$500 approved for @eVoloshchak