[HOLD for payment 2024-03-19] [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] [Workflows] Workflow - Weekly submission frequency is not selected by default

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.47-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): nathanmulugetatesting@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #37213

Action Performed:

1. Create a new Collect policy on OldDot
2. Enable the Collect workspace to show up on NewDot
3. Login to NewDot, then navigate to Settings > Workspaces. You should see your Collect workspace, click on it
4. Click on Workflows
5. Toggle the Submission frequency sub item. A submenu should open and observe the default value

Expected Result:

Weekly should be set as the default value

Actual Result:

No value is set as the default value

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6402902_1709649283440.submissionFrequencyBug.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[luacmartins]

cc @lakchote

[luacmartins]

Hmm I actually think the correct solution is to optimistically set weekly as the autoReportingFrequency

[roryabraham]

requested retest: https://expensify.slack.com/archives/C9YU7BX5M/p1709690076933769?thread_ts=1709689981.868779&cid=C9YU7BX5M

[luacmartins]

Demoting to NAB. The remaining issue will be fixed by https://github.com/Expensify/Auth/pull/10076

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Fix default autoreportingfrequency #37786

If no regressions arise, payment will be issued on 2024-03-13. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Fix default autoreportingfrequency #37786

If no regressions arise, payment will be issued on 2024-03-14. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Weekly submission frequency not selected by default #37821

If no regressions arise, payment will be issued on 2024-03-19. 🎊

[melvin-bot]

@luacmartins Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[luacmartins]

We're good to close here since the PR was handled internally - #37786