[HOLD for payment 2024-03-14] [$500] Video - App crashes when opening video in full screen while it is still loading

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.47-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to chat.
3. Send a video.
4. Play the video.
5. Click on the expand button while the video is still loading.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6402236_1709602613392.bandicam_2024-03-05_06-09-20-144__1_.mp4

Bug6402236_1709602613462!video_crash.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010dfc1052e95c8db2
• Upwork Job ID: 1764961446011293696
• Last Price Increase: 2024-03-05

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

We think that this bug might be related to #vip-vsb
cc @quinthar

[m-natarajan]

@techievivek FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[abzokhattab]

not reproducible from my side on the latest main

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when trying to expand video while it is initially loading.

What is the root cause of that problem?

currentVideoPlayerRef.current is null in bindFunctions.

What changes do you think we should make in order to solve the problem?

Null check needs to be added.

const bindFunctions = useCallback(() => {
        if (currentVideoPlayerRef.current == null) {
            return
        }
        currentVideoPlayerRef.current._onPlaybackStatusUpdate = handlePlaybackStatusUpdate;
        currentVideoPlayerRef.current._onFullscreenUpdate = handleFullscreenUpdate;
        // update states after binding
        currentVideoPlayerRef.current.getStatusAsync().then((status) => {
            handlePlaybackStatusUpdate(status);
        });
    }, [currentVideoPlayerRef, handleFullscreenUpdate, handlePlaybackStatusUpdate]);

[techievivek]

Hmm, I am still able to reproduce it on staging.

[techievivek]

It doesn't need to be a blocker.

[bernhardoj]

It's a regression from #36833. The attachment carousel is supposed to use the shared video ref, but because this useEffect is added, the video ref is overwritten with null.

App/src/components/VideoPlayer/BaseVideoPlayer.js

Lines 147 to 149 in eb4683d

	useEffect(() => {
	currentVideoPlayerRef.current = videoPlayerRef.current;
	}, [url, currentVideoPlayerRef]);

[ShridharGoel]

@techievivek Can you check my proposal?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010dfc1052e95c8db2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[aimane-chnaif]

This is crash. Is it fine to demote this as NAB?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix crash when expanding video player #37772

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment (Needs manual offer from BZ)
• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR MAR 13 14

• Fix:@bernhardoj [$500 - if no regressions] Offer Link
• PR Review: @aimane-chnaif [$500 - if no regressions] Offer Link
  please complete checklist above

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix crash when expanding video player #37772

If no regressions arise, payment will be issued on 2024-03-14. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment (Needs manual offer from BZ)
• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR MAR 14

• Fix: @bernhardoj [$500 - if no regressions] Offer Link
• PR Review: @aimane-chnaif [$500 - if no regressions] Offer Link

[abekkala]

@bernhardoj payment sent and contract ended - thank you! 🎉

@aimane-chnaif can you please complete the checklist above and I can release payment. Thanks!

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: FIx downloading video crash #37122
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37122/files#r1525005774
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

We can skip regression test as this was deploy blocker (caught in staging regression test)

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @bernhardoj paid $(AMOUNT) via Upwork (LINK)
• ROLE: @aimane-chnaif paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1764961446011293696/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[abekkala]

wow - melvin, you're pretty late. I already took care of this!

[abekkala]

@aimane-chnaif payment sent and contract ended - thank you! 🎉