Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-13] [HOLD for payment 2024-03-11] IOU - Multilevel Tags Dependent are not displayed correctly in the created IOU #37658

Closed
5 of 6 tasks
lanitochka17 opened this issue Mar 2, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.46-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4356155
Email or phone of affected tester (no customers): sustinov@applausemail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Preconditions:
In OldDot under admin, create a Collect group policy, enable tags and upload dependent tags to the policy - File can be found here https://drive.google.com/file/d/1MZ2-8EC7z632cvpZHXch0MHXZMpFgYWS/view?usp=drive_link,
add the employee to the policy. Setup OldDot Collect Policy:
https://sites.google.com/applausemail.com/applause-expensifyproject/wiki-guides/newdot-categories?authuser=0

  1. Open https://staging.new.expensify.com/
  2. Log in to the employee's account
  3. Tap on the green plus button (FAB)
  4. Select Request money
  5. Select any currency and amount
  6. Click next
  7. Choose a group policy room
  8. Click on "Show more"
  9. Enter all required fields
  10. Complete the IOU request
  11. Navigate to the details of the created IOU
  12. Click on the Region or State field

Expected Result:

Multilevel Tags - Dependent must be displayed correctly in the created IOU

Actual Result:

Multilevel Tags - Dependent are not displayed correctly in the created IOU

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6399229_1709364006049.Recording__1398.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 2, 2024
Copy link
Contributor

github-actions bot commented Mar 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 2, 2024

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave6
CC @greg-schroeder

@lanitochka17
Copy link
Author

@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@rlinoz
Copy link
Contributor

rlinoz commented Mar 4, 2024

It looks like frontend as we seem to have the correct information
Screenshot 2024-03-04 at 11 21 29
Screenshot 2024-03-04 at 11 22 04

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Mar 4, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 4, 2024
@melvin-bot melvin-bot bot changed the title IOU - Multilevel Tags Dependent are not displayed correctly in the created IOU [HOLD for payment 2024-03-11] IOU - Multilevel Tags Dependent are not displayed correctly in the created IOU Mar 4, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 4, 2024
Copy link

melvin-bot bot commented Mar 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-11. 🎊

@getusha
Copy link
Contributor

getusha commented Mar 4, 2024

@rlinoz could you assign me here for the C+ role?

@rlinoz rlinoz removed the DeployBlockerCash This issue or pull request should block deployment label Mar 5, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Mar 5, 2024

CP validated, removing deploy blocker

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 6, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-03-11] IOU - Multilevel Tags Dependent are not displayed correctly in the created IOU [HOLD for payment 2024-03-13] [HOLD for payment 2024-03-11] IOU - Multilevel Tags Dependent are not displayed correctly in the created IOU Mar 6, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

  • @getusha requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 11, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

Issue is ready for payment but no BZ is assigned. @abekkala you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Mar 13, 2024

Payment Summary

Upwork Job

  • ROLE: @getusha paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@abekkala)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Mar 13, 2024

Not overdue, Melvin just assigned @abekkala to handle payment.

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2024
@abekkala
Copy link
Contributor

@rlinoz is this PR review a $250 review? Or is it $500?

@rlinoz
Copy link
Contributor

rlinoz commented Mar 14, 2024

I think it should be the full amount, since this wasn't a regression, just a feature in development.

@abekkala
Copy link
Contributor

@getusha I'm having a hard time finding your Upwork profile. Can you link it here?

@getusha
Copy link
Contributor

getusha commented Mar 15, 2024

@abekkala here https://www.upwork.com/freelancers/~01460cf774c356f209

@abekkala
Copy link
Contributor

@getusha offer sent!

@getusha
Copy link
Contributor

getusha commented Mar 15, 2024

@abekkala accepted.

@abekkala
Copy link
Contributor

@getusha payment sent and contract ended - thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants