Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-13] [$250] [TS migration] Migrate '[Components Group 1]' component to TypeScript #36273

Closed
fabioh8010 opened this issue Feb 9, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration

Comments

@fabioh8010
Copy link
Contributor

fabioh8010 commented Feb 9, 2024

Typescript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Issues

#36125
#36126
#36127
#36128

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015c98da9b39ab326a
  • Upwork Job ID: 1757748780958019584
  • Last Price Increase: 2024-02-14
  • Automatic offers:
    • s77rt | Reviewer | 0
    • rayane-djouah | Contributor | 0
@fabioh8010 fabioh8010 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@rayane-d
Copy link
Contributor

I would like to work on this

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

@zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 14, 2024
@rayane-d
Copy link
Contributor

Would like to work on this

Copy link

melvin-bot bot commented Feb 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015c98da9b39ab326a

@melvin-bot melvin-bot bot changed the title [TS migration] Migrate '[Components Group 1]' component to TypeScript [$500] [TS migration] Migrate '[Components Group 1]' component to TypeScript Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Current assignee @zanyrenney is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Daily KSv2 Overdue labels Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 14, 2024
@mountiny mountiny changed the title [$500] [TS migration] Migrate '[Components Group 1]' component to TypeScript [$250] [TS migration] Migrate '[Components Group 1]' component to TypeScript Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Upwork job price has been updated to $250

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Feb 14, 2024

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@s77rt
Copy link
Contributor

s77rt commented Feb 14, 2024

@mountiny I think this is just a tracking issue? Nothing to migrate here

@rayane-d
Copy link
Contributor

I think that the 4 issues are combined in one issue, because each issue have only one file. We should work on all of them. @mountiny could you confirm please?

@mountiny
Copy link
Contributor

Correct this is an issue combining couple smaller simpler files. All should be handled in one PR

Copy link

melvin-bot bot commented Feb 25, 2024

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 6, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate '[Components Group 1]' component to TypeScript [HOLD for payment 2024-03-13] [$250] [TS migration] Migrate '[Components Group 1]' component to TypeScript Mar 6, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 6, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@s77rt
Copy link
Contributor

s77rt commented Mar 6, 2024

No regression test needed since it's not a NewFeature

@rayane-d
Copy link
Contributor

@zanyrenney Friendly reminder for payment 😄

@zanyrenney
Copy link
Contributor

It's been a day since payment is due 😅 please be patient.

@zanyrenney
Copy link
Contributor

zanyrenney commented Mar 14, 2024

payment summary

@s77rt requires payment automatic offer (Reviewer) paid $250 on UW
@rayane-djouah requires payment automatic offer (Contributor) paid $250 on UW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration
Projects
No open projects
Development

No branches or pull requests

6 participants