[$500] Request money - Deleted request shows empty details when the details page has messages

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.24-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to workspace chat.
2. Create any request.
3. Go to the details page and send a message.
4. Click 3-dot menu > Delete request.
5. Delete the request.

Expected Result:

The request details page will be blank except the bottom part where it shows messages (previous behavior).

Actual Result:

The request details page shows empty details (Amount, date, description etc).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6339833_1705045583836.20240111_215828.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d86a2dfc9f2be794
• Upwork Job ID: 1745748245116649472
• Last Price Increase: 2024-02-02
• Automatic offers:
• dukenv0307 | Contributor | 28142050

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d86a2dfc9f2be794

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The request details page shows empty details (Amount, date, description etc).

What is the root cause of that problem?

We always display MoneyRequestView in transaction thread report

App/src/pages/home/report/ReportActionItem.js

Line 579 in b6a18b1

<MoneyRequestView

What changes do you think we should make in order to solve the problem?

We can display [Deleted Request] message if the transaction is deleted the same way as we do for the canceled task.

We can do that by checking ReportActionsUtils.isDeletedParentAction(parentReportAction)

App/src/pages/home/report/ReportActionItem.js

Line 579 in b6a18b1

<MoneyRequestView

App/src/pages/home/report/ReportActionItem.js

Line 587 in b6a18b1

if (ReportUtils.isCanceledTaskReport(props.report, parentReportAction)) {

What alternative solutions did you explore? (Optional)

In MoneyRequestView, we can return null or return [Deleted Request] if the transaction is deleted (is undefined) or check ReportActionsUtils.isDeletedParentAction(parentReportAction) as we do in MoneyRequestAction

[bernhardoj]

The temporary code to hide the money request view was cleaned up in #33633

cc: @youssef-lr

[dukenv0307]

Actually, we are using transaction as props in MoneyRequestView, so we can do it as a new issue to fix this case.

[melvin-bot]

@sobitneupane, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

@dukenv0307 are you recommending that this issue is closed and a new bug report created?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[muttmuure]

@sobitneupane shall we close this one?

[sobitneupane]

@muttmuure I will be able to review the proposals only in weekend. I am working partially and won't be able to prioritize the issue. Please feel free to re-assign the issue in case of higher-priority.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sobitneupane, @muttmuure Huh... This is 4 days overdue. Who can take care of this?

[MariaHCD]

Not overdue, proposal was just accepted.

[muttmuure]

Not overdue

[melvin-bot]

@MariaHCD @allroundexperts @muttmuure @dukenv0307 this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

[muttmuure]

@dukenv0307 are you able to start on your PR?

[dukenv0307]

I'm on a traditional holiday until tomorrow. PR is prepared locally, will open this tomorrow.

[dukenv0307]

@allroundexperts The PR is ready for review.

[melvin-bot]

This issue has not been updated in over 15 days. @MariaHCD, @allroundexperts, @muttmuure, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[allroundexperts]

This was deployed to production 2 weeks ago. I think we're just pending the payment here. cc @muttmuure

[muttmuure]

$500 - @allroundexperts for C+
$500 - @dukenv0307 paid on Upwork

[JmillsExpensify]

$500 approved for @allroundexperts

[melvin-bot]

This issue has not been updated in over 14 days. @MariaHCD, @allroundexperts, @muttmuure, @dukenv0307 eroding to Weekly issue.