Deprecate the hasOutstandingIOU key on reports

[mountiny]

Problem

We have been using the hasOutstandingIOU key to indicate that there is some active (ie processing or open) report linked to chat report or as a property on the money request report to indicate the same.

In case of IOU/expense report its however redundant as we know the state and status and total so we can derive if the report is active

In case of the parent chat reports (DM in case of IOU and workspace chat in case of expense report) we now have the hasChildOutstandingRequest property which indicates there is action required from the user.

The hasOutstandingIOU property now became redundant so we can remove it

Solution

Lets remove this key from the App

• MoneyRequestAction here on the parent chat report whether to show pending report action, I think we can change this to chatReport?.iouReportID instead because the report should only be linked if its outstanding
• updateIOUReportOwner - can be removed
• in optionsListUtils - can be removed
• getMoneyRequestReimburseableTotal - can be removed
• getMoneyRequestSpendBreakdown - can be removed
• getMoneyRequestReportName - we can substitute it with checking for the report state and status to be 1, 1
  • I think will be updating this to handle the approved case to say approved cc @marcochavezf
• SidebarUtils, can be removed

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ccb3eb4568689c3
• Upwork Job ID: 1732700650759397376
• Last Price Increase: 2023-12-07

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ccb3eb4568689c3

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @cubuspl42 (Internal)

[mountiny]

PRs to deprecate this in backend are ready and on hold for the app changes first

[rezkiy37]

Gut!
I am preparing a PR today.

[rezkiy37]

Still testing, just resolved unit tests. Going to open the PR tomorrow.

[cubuspl42]

Review in progress

[mountiny]

Merged

[mountiny]

Payment handled here #32281

[cubuspl42]

@mountiny Do we hold on anything in such case, or are we good to close this one?

[mountiny]

I need to clean this up in the backend but your payment can be handled already

[rezkiy37]

@mountiny, just carious any updates on this issue?

[mountiny]

I need to follow through on the PRs which were created in the backend as HOLD now

[melvin-bot]

This issue has not been updated in over 15 days. @mountiny, @rezkiy37 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

This was done already