Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split bill - Does nothing when clicking on "Split bill preview" #32122

Closed
6 tasks done
kbecciv opened this issue Nov 28, 2023 · 8 comments
Closed
6 tasks done

Split bill - Does nothing when clicking on "Split bill preview" #32122

kbecciv opened this issue Nov 28, 2023 · 8 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Nov 28, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.4.0
Reproducible in staging?: y
Reproducible in production?: no (crash on production)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31291

Action Performed:

  1. Create a workspace if you don't have one
  2. Open the #announce room
  3. Do a split bill in the room
  4. Log in on another device (with the same/different account, if you use a different account, make sure invite it to the workspace)
  5. Visit the #announce room
  6. The split bill preview should show as a skeleton
  7. Press the preview

Expected Result:

Verify a not found page is shown and that no crash happens.

Actual Result:

Does nothing when clicking on "Split bill preview"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6293235_1701179493880.Recording__269.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 28, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@bernhardoj
Copy link
Contributor

This is the expected behavior. See #32078 (comment)

@situchan
Copy link
Contributor

Seems expected but there should have been UX discussion with design team

@iwiznia
Copy link
Contributor

iwiznia commented Nov 28, 2023

Ah ok, so not a blocker and expected it seems. I am not sure what other thing we could do to improve UX... tagging @Expensify/design to get their opinions.

@shawnborton
Copy link
Contributor

Hmm but the mouse is just a standard mouse cursor and not a pointer cursor, so from a visual feedback perspective, the user would know there is nothing to click on right?

@iwiznia
Copy link
Contributor

iwiznia commented Nov 28, 2023

Yep, that's right. So close it?

@shawnborton
Copy link
Contributor

That's my vote, yup.

@iwiznia iwiznia closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants