[HOLD for payment 2023-12-29] Android - Distance - Location permission prompt reappears after declining it

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.4.0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #30506

Action Performed:

Precondition:

• The device used is a Samsung device with Android 12.
• App location permission is reset.

1. Launch New Expensify app.
2. Tap + > Request money > Distance.
3. Don't allow location access.
4. Wait for a while.

Expected Result:

Location permission prompt will not reappear.

Actual Result:

Location permission prompt appears again.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6293229_1701179208961.Screen_Recording_20231128_142647_Permission_controller.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[flodnv]

Pinged @neil-marcellini here in Slack since he's been working on this feature

[neil-marcellini]

Here is the PR that caused this Automatically pan initial map based on current location. It's not reproducible on production because this is a new feature. I don't think it's a significant enough issue to be worth blocking deploy. If you agree I'll remove the label. Let's start looking into a fix regardless.

[flodnv]

Reassigning to @thienlnam as per the Slack discussion

[thienlnam]

@MaciejSWM is going to be looking into this - likely will get around to it tommorow

[MaciejSWM]

@thienlnam a draft PR created.

It’s a draft so far. Let me highlight that I didn’t try to replicate the real issue, I only presented a possible solution to what I think might be the issue. Feel free to continue exploring based on my PR and present the final solution if this bug is urgent, or let me know if I should investigate and present the final fix tomorrow

[thienlnam]

@MaciejSWM Have you had a chance to get back to this yet?

[thienlnam]

Bump @MaciejSWM

[thienlnam]

Pinged in https://expensify.slack.com/archives/C04878MDF34/p1702331990995889

[melvin-bot]

@thienlnam, @MaciejSWM Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MaciejSWM]

Reproduced on physical Android. The exact issue presented above is not reproducible, only after some minor changes in the code. What is reproducible though is that when I land on Distance tab and deny access, then go to other tab and then back to Distance, then I get asked for the second time. Fixing both those issues with one change. PR soon.

[MaciejSWM]

@thienlnam PR is ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix] Double consent ask #33157

If no regressions arise, payment will be issued on 2023-12-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @MaciejSWM does not require payment (Contractor)

[melvin-bot]

@thienlnam, @MaciejSWM Eep! 4 days overdue now. Issues have feelings too...

[thienlnam]

Assigning s77rt for C+ review payment

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[thienlnam]

Here's the PR #33157

We just need a payment to C+ s77rt for reviewing
The contributor that handled the changes is from SWM

[isabelastisser]

@s77rt I sent you an offer in Upwork.

All set!

[s77rt]

@isabelastisser Accepted! I think the payment due here is $500