Request money - 3-dot menu does not disappear after deleting money request

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Issue found when executing PR #28214

Action Performed:

1. Go to staging.new.expensifail.com or open iOS, Android, Desktop App
2. Login with any account
3. Create a request money
4. Go to the transaction thread report of the request
5. Send a message in this report
6. Click on the 3-dot icon in the header and delete the request
7. Verify that the 3-dot icon is hidden after the request is deleted

Expected Result:

3-dot icon is hidden after the request is deleted

Actual Result:

3-dot icon is NOT hidden after the request is deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6237343_1697314655361.28214_Android.mp4

Android: mWeb Chrome

iOS: Native

Bug6237343_1697314655352.28214_iOS.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6237343_1697314655361.28214_Web_Safari.mp4

MacOS: Desktop

Bug6237343_1697314655362.28214_Desktop.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[shubham1206agra]

Can you confirm me the ideal behaviour?

[ishpaul777]

Problem

3-dot menu does not disappear after deleting money request

Root cause

We are not hiding the threeDot menu option in MoneyRequestHeader when the request is deleted. The three dot is still visible. ref- https://github.com/Expensify/App/blob/0b06446b0bd420550ccc9896bd0f9bf8d57e90e2/src/components/MoneyRequestHeader.js
This looks like a bad merge commit that cause this issue and videos recorded in the PR are prior mege.

App/src/components/MoneyRequestHeader.js

Line 119 in 0b06446

shouldShowThreeDotsButton

Changes

on HeaderWithBackButton in MoneyRequestHeader, we need to have condition to hide the 3 dot menu.

shouldShowThreeDotsButton={!ReportActionsUtils.isDeletedAction(parentReportAction)}
// or shouldShowThreeDotsButton={canModifyTask} 
//(canModifyRequest = isActionOwner && !isSettled && !isApproved && !ReportActionsUtils.isDeletedAction(parentReportAction);)

[mountiny]

I dont think this has to be a blocker and @dukenv0307 should handle this regression as it was clearly bad merge conflict

[ishpaul777]

I can work on this @mountiny and raise a PR within few hours.

[dukenv0307]

@mountiny It's always as true in this PR #29078 since we have pin option for iou report.

[mountiny]

This is the request page, I am not sure, @jasperhuangg @trjExpensify what do you think, should we close this as expected?

[trjExpensify]

If a request is preserved because of the comments in the transaction thread, I don't see why we wouldn't let you pin it still. So then in that regard, because the pin action is now a menu item within the overflow menu, it makes sense to remain in this scenario.

[mountiny]

I will close this issue then