Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-23] #27691

Closed
1 of 6 tasks
aldo-expensify opened this issue Sep 18, 2023 · 36 comments
Closed
1 of 6 tasks

[HOLD for payment 2023-10-23] #27691

aldo-expensify opened this issue Sep 18, 2023 · 36 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority Reviewing Has a PR in review

Comments

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Sep 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to DM chat
  2. Click + and then "Request Money"
  3. Use "Scan" option and try to take a picture

Expected Result:

After giving permissions to the app, the camera should appear

Actual Result:

After giving permissions to the app, a loading spinner stays there forever

image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native - Specifically a Xiaomi A3 device
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d479b9dfa637bcca
  • Upwork Job ID: 1704032011382767616
  • Last Price Increase: 2023-09-19
@aldo-expensify aldo-expensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@aldo-expensify
Copy link
Contributor Author

Solution:

Marc fixed this here: mrousavy/react-native-vision-camera#1782

We need to update react-native-vision-camera to get the fix

@MitchExpensify
Copy link
Contributor

Is the idea to label this external still @aldo-expensify ? I do not have access to a Xiaomi so I'm tempted to go straight to that step 😅

@AndrewGable
Copy link
Contributor

AndrewGable commented Sep 19, 2023

This was released in 2.16.1 - I can update it

@AndrewGable AndrewGable self-assigned this Sep 19, 2023
@AndrewGable AndrewGable added the Internal Requires API changes or must be handled by Expensify staff label Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01d479b9dfa637bcca

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary (Internal)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 20, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

This issue has not been updated in over 15 days. @AndrewGable, @ntdiary, @MitchExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Oct 16, 2023
@melvin-bot melvin-bot bot changed the title Camera doesn't work for Xiaomi A3 [HOLD for payment 2023-10-23] Camera doesn't work for Xiaomi A3 Oct 16, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
  • [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@ntdiary] Determine if we should create a regression test for this bug.
  • [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 16, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jan 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 9, 2024
@MitchExpensify
Copy link
Contributor

Hold for #30732 which found a home on a wave so progress will continue

@melvin-bot melvin-bot bot removed the Overdue label Jan 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 17, 2024
@MitchExpensify
Copy link
Contributor

Hold for #30732

@MitchExpensify
Copy link
Contributor

Hold for #30732

@melvin-bot melvin-bot bot removed the Overdue label Jan 31, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 8, 2024
@MitchExpensify
Copy link
Contributor

Hold for #30732

@melvin-bot melvin-bot bot removed the Overdue label Feb 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 22, 2024
@MitchExpensify
Copy link
Contributor

Hold for #30732

@melvin-bot melvin-bot bot removed the Overdue label Feb 23, 2024
@MitchExpensify
Copy link
Contributor

Hold for #30732

Copy link

melvin-bot bot commented Apr 5, 2024

This issue has not been updated in over 15 days. @AndrewGable, @ntdiary, @MitchExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 5, 2024
@MitchExpensify
Copy link
Contributor

Hold for #30732

@MitchExpensify MitchExpensify changed the title [HOLD for payment 2023-10-23]Camera doesn't work for Xiaomi A3 [HOLD for payment 2023-10-23] Apr 8, 2024
@melvin-bot melvin-bot bot closed this as completed Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

@AndrewGable, @ntdiary, @MitchExpensify, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants