[$1000] LHN - Instead of user name, "chat report " is displayed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch app
2. Tap profile icon
3. Tap workspaces
4. Tap any Workspace
5. Tap Members
6. Tap invite
7. Enter any new non-existing account
8. Tap Next
9. Tap Invite
10. Navigate to LHN

Expected Result:

The invited workspace user name should display in the first line of report in the LHN

Actual Result:

"Chat report" is displayed in the first line of report in the LHN instead of the invited workspace user name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6186538_chat_report_in_lhn.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5e746cb88e86963
• Upwork Job ID: 1698644415415676928
• Last Price Increase: 2023-09-28

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[conorpendergrast]

Oh yeah, weird:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5e746cb88e86963

[im-adithya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Chat Report" is displayed instead of username

What is the root cause of that problem?

Because we send in undefined (second param, reportName) to buildOptimisticChatReport while creating the chat, see

App/src/libs/actions/Policy.js

Line 290 in f9f0ba5

const optimisticReport = ReportUtils.buildOptimisticChatReport([sessionAccountID, cleanAccountID], undefined, CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT, policyID, cleanAccountID);

What changes do you think we should make in order to solve the problem?

We can send the email as the reportName instead of undefined

What alternative solutions did you explore? (Optional)

< Thinking >

[Santhosh-Sellavel]

@conorpendergrast Unassigning this one due to low bandwidth, can you assign a new C+ by applying external label again, thanks!

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

This seems like a regression because I am sure we fixed it before.

[parasharrajat]

@im-adithya The Root cause is incorrect/incomplete thus the solution.

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Instead of the user name, "chat report " is displayed

What is the root cause of that problem?

When API has write access we store it in the ONYXKEYS.QUEUED_ONYX_UPDATES

App/src/libs/actions/OnyxUpdates.ts

Line 22 in 41ddd74

const updateHandler = request?.data?.apiRequestType === CONST.API_REQUEST_TYPE.WRITE ? QueuedOnyxUpdates.queueOnyxUpdates : Onyx.update;

when ONYXKEYS.PERSISTED_REQUESTS completes all the requests we are flushed out (ONYXKEYS.QUEUED_ONYX_UPDATES) to onyx update.

App/src/libs/Network/SequentialQueue.js

Line 126 in 41ddd74

flushOnyxUpdatesQueue();

so at the time, it became a race condition.

What changes do you think we should make in order to solve the problem?

https://github.com/Expensify/react-native-onyx/blob/82b5372aa6fef416408bbe71986029e18793e43a/lib/Onyx.js#L1367-L1408
here we are calling in async mode this will become a race condition. we need to make sync mode.

Additional context

the web also has this issue. I think in issue in onyx.update functions because data is not presist in the database properly.

Untitled.mov

why we see initially the username means before presist the data in the database callback will be triggered. so that we can see that refresh.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[cubuspl42]

@Julesssss So, is this issue classified as an agency issue now? Should we remove the "Help wanted" label? Or should I review the proposal and continue as usual?

[pradeepmdk]

@cubuspl42 @paultsimura could you verify this issue again because now not able to reproduce it in staging.

because now recently updated react-native onyx fixed some performance issue as well.

Untitled.mp4

[ospfranco]

I also just tested this on main and cannot reproduce it. Let me know if anyone is still having an issue.

[melvin-bot]

@cubuspl42 @Julesssss @mallenexpensify this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @cubuspl42 is eligible for the Internal assigner, not assigning anyone new.

[Julesssss]

I'm also unable to reproduce. but that doesn't prove that the out-of-order updates are no longer occuring, so I think we should do the following:

• Close this issue
• @paultsimura create a new bug for the out-of-order updates that you discovered, we can continue that investigation and pay out for your help separately from this issue

[paultsimura]

Thank you @Julesssss, I will report a bug and will tag you in the thread.

[Julesssss]

I'll keep this issue open until that issue is created, just so we don't forgot

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[mallenexpensify]

Closing cuz I think we were waiting for the below to be created, and it is!

• [$1000] Web - Onyx: out-of-order updates #28737

[ospfranco]

My changes on #28737 were reverted. The change caused issues in other places of the app. You should probably re-open this again.

[mallenexpensify]

Thanks @ospfranco

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[mallenexpensify]

Closing cuz it's not reproducible.