[HOLD for payment 2023-10-02] [$500] Leaving threads lands you in concierge chat

[MitchExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

"leave" a thread via settings

Expected Result:

Get dropped in the parent thread. Link to the specific reportAction (even though for now that will just take you to the bottom of the report)

Actual Result:

You will be taken to your concierge chat.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): monika.szczygiel@callstack.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://github.com/Expensify/App/assets/36425901/c3d741db-d2be-46f4-82f7-166cb7c308e5
Expensify/Expensify Issue URL:
Issue reported by: mitch@expensify.com
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b9d7890bbfeaba17
• Upwork Job ID: 1701115791590625280
• Last Price Increase: 2023-09-11
• Automatic offers:
• Ollyws | Reviewer | 26604173
• tienifr | Contributor | 26604176

[melvin-bot]

Current assignee @MitchExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MonikaSzczygiel]

Hi folks! Additional notes:

1. The issue occurs when you try to leave either thread or room - inability to leave - redirecting back to thread or room
2. The thread/room doesn't disappear from the home page (main view)

Actions performed:

1. "Leave" a room or thread via settings

A) Click "<" and wait for 1 sec. when you land in your Concierge DM - you'll be redirected back to settings tab
B) Quickly click "go back to the home page" when you land in your Concierge DM - you'll be redirected back to thread/room you tried to leave

[melvin-bot]

📣 @MonikaSzczygiel! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mountiny]

@roryabraham this is fixed in staging for a while but due to the apple review process there was no production release in a while
https://github.com/Expensify/App/assets/36083550/281fc1e1-de3c-42e5-b5d5-5c759c8f1347

I think the only pending question in this issue is: should we navigate to the parent chat when leaving a thread instead of the concierge chat?

[roryabraham]

I did some testing in 1.3.61-2 and this seems to work correctly for me.

I think the only pending question in this issue is: should we navigate to the parent chat when leaving a thread instead of the concierge chat?

Yes, this sounds like a good improvement to me (we should also link to the root reportAction, which currently doesn't do anything but once comment linking is done will center the report on the thread you just left) 👍🏼

[MitchExpensify]

should we navigate to the parent chat when leaving a thread instead of the concierge chat?

Agree this is desired.

[roryabraham]

I'm not sure if this can really be treated as a pre-conference priority at this point. Fortunately, landing on the concierge chat when you leave a thread is not really breaking the app, and it's not really a mainline case anyways. So I'd suggest that we create a separate follow-up to patch that and fix it after the merge freeze

[MitchExpensify]

Yes, lets add this as a follow up item

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b9d7890bbfeaba17

[melvin-bot]

Triggered auto assignment to @sonialiap (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

PR ready for review #27127

[MitchExpensify]

Some feedback in the PR for you here @tienifr 👀

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @tienifr got assigned: 2023-09-11 06:51:59 Z
• when the PR got merged: 2023-09-20 13:08:33 UTC
• days elapsed: 7

On to the next one 🚀

[roryabraham]

PR merged. @MitchExpensify we should pay the #urgency bonus for this PR. It was ready and approved within the limit, and just sat waiting for my review for 5 days before being final-approved and merged.

[MitchExpensify]

Payment summary:

Reporter: NA
C: $750 @tienifr (Upwork)
C+: $750 @Ollyws (Upwork)

[MitchExpensify]

Offer still pending for you @Ollyws just a heads up https://www.upwork.com/nx/wm/offer/26604173

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Leaving thread navigates to Concierge page #27127

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment offer (Reviewer)
• @tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Added a reminder to pay on October 2nd, please take a look at the BZ steps above when you get a chance @Ollyws

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Ollyws]

There was no PR that introduced this as a bug as it was the previous, intentional behaviour.
I don't think a regression test is helpful here as it's not an impactful issue or related to an important user flow.
So I don't think the checklist is helpful here, let me know if you think otherwise.

[MitchExpensify]

Sounds good to me, @Ollyws !

Issuing payment now

[MitchExpensify]

Paid and contracts ended, thanks all!