Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-13] [$250] [TS migration] Migrate 'Expensify.js' file to TypeScript #25231

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 24 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/Expensify.js 33
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019006577fc891c147
  • Upwork Job ID: 1750843547845558272
  • Last Price Increase: 2024-01-26
  • Automatic offers:
    • mollfpr | Reviewer | 28123424
    • dukenv0307 | Contributor | 28123425
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@JKobrynski
Copy link
Contributor

TODO: remove @ts-expect-error from useAutoFocusInput.ts (check this comment)

@dummy-1111
Copy link
Contributor

Dibs

@melvin-bot melvin-bot bot added the Overdue label Jan 26, 2024
@abzokhattab
Copy link
Contributor

I can work on this

@shahinyan11
Copy link

I would like to work on it

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jan 26, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Expensify.js' file to TypeScript [$500] [TS migration] Migrate 'Expensify.js' file to TypeScript Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019006577fc891c147

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2024
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'Expensify.js' file to TypeScript [$250] [TS migration] Migrate 'Expensify.js' file to TypeScript Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Monthly KSv2 labels Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@Temidayo32
Copy link

Great!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jan 29, 2024
@dukenv0307
Copy link
Contributor

@mollfpr The PR is ready for review.

Copy link
Author

melvin-bot bot commented Feb 7, 2024

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Feb 21, 2024
Copy link
Author

melvin-bot bot commented Feb 21, 2024

This issue has not been updated in over 15 days. @sakluger, @lakchote, @mollfpr, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Feb 21, 2024
@dukenv0307
Copy link
Contributor

dukenv0307 commented Feb 23, 2024

@lakchote The PR #35296 is ready for review. Bot auto-assign fails.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 Weekly KSv2 labels Mar 1, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'Expensify.js' file to TypeScript [HOLD for payment 2024-03-13] [$250] [TS migration] Migrate 'Expensify.js' file to TypeScript Mar 6, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 6, 2024
Copy link
Author

melvin-bot bot commented Mar 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Mar 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Mar 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 13, 2024
@sakluger
Copy link
Contributor

Summarizing payment on this issue:

Contributor: @dukenv0307 $250, paid via Upwork
Contributor+: @mollfpr $250, please request on Newdot

No regression test steps needed for TS migration issues.

@JmillsExpensify
Copy link

$250 approved for @mollfpr based on summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests