Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-12] [Pay 12/8] [TS migration] Migrate 'AnonymousReportFooter.js' component to TypeScript #25058

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/AnonymousReportFooter.js 11
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@melvin-bot melvin-bot bot added the Overdue label Oct 27, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Copy link
Author

melvin-bot bot commented Nov 30, 2023

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hoangzinh
Copy link
Contributor

@stitesExpensify I'm assigned to review the PR #31916. Can you help me to assign me to this issue and also add/remove label bug so Melvin auto assign a BZ member here

@stitesExpensify stitesExpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 30, 2023
Copy link
Author

melvin-bot bot commented Nov 30, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 30, 2023
Copy link
Author

melvin-bot bot commented Nov 30, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@stitesExpensify stitesExpensify added Weekly KSv2 and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 30, 2023
@hoangzinh
Copy link
Contributor

Thanks @stitesExpensify

@bfitzexpensify bfitzexpensify added Daily KSv2 and removed Weekly KSv2 labels Dec 3, 2023
@bfitzexpensify bfitzexpensify changed the title [TS migration] Migrate 'AnonymousReportFooter.js' component to TypeScript [Pay 12/8] [TS migration] Migrate 'AnonymousReportFooter.js' component to TypeScript Dec 3, 2023
@bfitzexpensify
Copy link
Contributor

Moving to daily for payment next week

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Dec 5, 2023
@melvin-bot melvin-bot bot changed the title [Pay 12/8] [TS migration] Migrate 'AnonymousReportFooter.js' component to TypeScript [HOLD for payment 2023-12-12] [Pay 12/8] [TS migration] Migrate 'AnonymousReportFooter.js' component to TypeScript Dec 5, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 5, 2023
Copy link
Author

melvin-bot bot commented Dec 5, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Dec 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 11, 2023
@bfitzexpensify
Copy link
Contributor

Offer sent @hoangzinh

@hoangzinh
Copy link
Contributor

Accepted. Thanks @bfitzexpensify

@bfitzexpensify
Copy link
Contributor

Paid out, we're all done here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Not a priority Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants