Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-06] [TS migration] Migrate 'DotIndicatorMessage.js' component to TypeScript #25046

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 29 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/DotIndicatorMessage.js 10
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Santhosh-Sellavel
Copy link
Collaborator

@nkuoch assign me for review here thanks!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 29, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'DotIndicatorMessage.js' component to TypeScript [HOLD for payment 2023-12-06] [TS migration] Migrate 'DotIndicatorMessage.js' component to TypeScript Nov 29, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 29, 2023
Copy link
Author

melvin-bot bot commented Nov 29, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Nov 29, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Dec 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@peterdbarkerUK
Copy link
Contributor

Apols Santosh, I've been out sick.

Contributor: @blazejkustra ($0 - expert)
C+ Review: @Santhosh-Sellavel $250 via newdot CC @JmillsExpensify

@melvin-bot melvin-bot bot removed the Overdue label Dec 19, 2023
@peterdbarkerUK
Copy link
Contributor

@JmillsExpensify is OoO, checking if we have a secondary way to pay

@peterdbarkerUK
Copy link
Contributor

peterdbarkerUK commented Dec 19, 2023

@Santhosh-Sellavel could you send a $250 payment request? @JmillsExpensify will take care of it once he returns from OoO

@melvin-bot melvin-bot bot added the Overdue label Dec 21, 2023
@anmurali
Copy link

I do not have access. I believe we have to wait for Mills. He will be back next week though.

@melvin-bot melvin-bot bot removed the Overdue label Dec 21, 2023
@anmurali anmurali removed their assignment Dec 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
Copy link
Author

melvin-bot bot commented Dec 25, 2023

@nkuoch, @peterdbarkerUK, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link
Author

melvin-bot bot commented Dec 27, 2023

@nkuoch, @peterdbarkerUK, @Santhosh-Sellavel Eep! 4 days overdue now. Issues have feelings too...

@peterdbarkerUK
Copy link
Contributor

@JmillsExpensify $250 for @Santhosh-Sellavel via NewDot please once it's been sent.

@melvin-bot melvin-bot bot added the Overdue label Dec 29, 2023
Copy link
Author

melvin-bot bot commented Jan 1, 2024

@JmillsExpensify, @nkuoch, @peterdbarkerUK, @Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

@JmillsExpensify
Copy link

I haven't received any requests via NewDot yet.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 3, 2024
Copy link
Author

melvin-bot bot commented Jan 8, 2024

@JmillsExpensify, @nkuoch, @peterdbarkerUK, @Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

@peterdbarkerUK
Copy link
Contributor

@Santhosh-Sellavel could you send a payment request for $250?

Copy link
Author

melvin-bot bot commented Jan 10, 2024

@JmillsExpensify, @nkuoch, @peterdbarkerUK, @Santhosh-Sellavel 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@Santhosh-Sellavel
Copy link
Collaborator

Request on ND

@JmillsExpensify
Copy link

$250 payment approved for @Santhosh-Sellavel based on comment above.

@melvin-bot melvin-bot bot removed the Overdue label Jan 12, 2024
@peterdbarkerUK
Copy link
Contributor

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

7 participants