[ECARD] CRITICAL: Settings - Create the “Empty state” view & Add Bank Accounts + Wallet tile

[grgia]

Design Doc Section

https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.659z4lc0lx22

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014a86de7e4b39b1e4
• Upwork Job ID: 1679789602202013696
• Last Price Increase: 2023-07-14

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014a86de7e4b39b1e4

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[shawnborton]

For this one, we have an animation we can use so we should be able to mimic the page header component that's being used on the Preferences page.

Then for the icons below it, we should be able to mimic the Lounge access page.

Happy to help with the assets when this is being worked on, just let me know!

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

I think @francoisl should not have been assigned to this issue as it is a "New Feature". Gonna remove that assignment now and see if we can get some volunteers.

[bfitzexpensify]

@marcaaron my bad. Let me sense check with you the right way to handle this. This SO says:

When an issue is labeled as NewFeature

If its in E/E repo add the Engineering label to auto-assign an internal engineer. That engineer can decide what they want to do with the issue - keep it, throw it to the pool, close it, etc.

If it’s in E/App repo, the issue will be auto-labeled as NewFeature and Weekly to ensure the issue is always being led internally.

I think that last sentence could probably be made a little clearer. I read 'always being led internally' and the fact that it wasn't assigned internally to mean that I should assign it via the Engineering label, especially given the instructions for the E/E repo, but it seems like that is incorrect.

What is correct? The engineer who opens the issue solicits volunteers, the Bug0/NewFeature assignee looks for volunteers, or will this automatically be shared somewhere where potential volunteers can see it?

[marcaaron]

Hmm idk then - I just think that it makes more sense to seek out a volunteer for an issue like this otherwise it might stay assigned to the auto-assigned engineer and cause confusion about whether they are expected to work on it or not.

[marcaaron]

fwiw I don't think you did anything wrong by adding the Engineering label here. Mostly just felt like it's a case where we have a project that is already being managed by a team and assigning someone random is less ideal than asking for a volunteer.

[bfitzexpensify]

Cool, gotcha, that makes sense

[melvin-bot]

@shawnborton, @narefyev91, @bfitzexpensify Still overdue 6 days?! Let's take care of this!

[pac-guerreiro]

I'm Pedro Guerreiro from Callstack, and I'll take this 😄

[melvin-bot]

@shawnborton, @narefyev91, @bfitzexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@shawnborton, @narefyev91, @bfitzexpensify, @pac-guerreiro 12 days overdue. Walking. Toward. The. Light...

[kevinksullivan]

Not overdue! PR is in review

[melvin-bot]

This issue has not been updated in over 15 days. @shawnborton, @narefyev91, @bfitzexpensify, @pac-guerreiro eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[kevinksullivan]

Still in review

[joekaufmanexpensify]

@narefyev91 as an fyi this is ready for re-review now!

[melvin-bot]

@shawnborton, @narefyev91, @grgia, @bfitzexpensify, @pac-guerreiro, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[kevinksullivan]

Hmm this should stay open, right @grgia ? It's not covered anywhere else? I know the "empty state" is no longer relevant with launch of wallet, but are we using this issue to show wallet + bank account tiles?

[kevinksullivan]

Ah I think this is actually just done and didn't close, my bad.