[HOLD for payment 2023-09-07] [$1000] Form Data Doesn't Save on Web Window Resize

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Happens in multiple Form flows, but here is one for example

1. Go to Profile > Display Name
2. Change your name but don't save
3. Resize the window (either go from small to large or large to small)

Expected Result:

Information typed in any kind of From in the App should stay

Actual Result:

The input fields revert to how they were before you changed them.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.25-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-06-07_11-16-30.mp4

Recording.902.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dangrous
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686161807163249

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01119cc6f3de38a706
• Upwork Job ID: 1666786232588369920
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Seems this line is causing this issue, bcoz when the screenWidth gets changed the key gets updated and it rerenders the component which eventually remounts AuthScreens component which calls openApp again and that is the problem.

[roryabraham]

Interesting find @Pujan92

[roryabraham]

Going to look into this.

[roryabraham]

Got a fix for this one ready: #20415

[roryabraham]

Ok, so my fix works for one instance of the problem, but it would be nice to come up with a generalized solution that works everywhere.

[roryabraham]

Chatted with @mountiny in slack and we decided to slow down on this. Because it's an edge case we're going to take the time to fix it right w/ a generalized solution and not block deploys on it.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [navigation-refactor] Style based approach for the three pane layout #22437

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @Swor71 does not require payment (Contractor)
• @WoLewicki does not require payment (Contractor)
• @adamgrzybowski does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

@mountiny how do we handle the payout here? We've had multiple C+ reviewers.

[mountiny]

@mananjadhav all of those who did full review should be paid here

[mananjadhav]

Thanks for the confirmation @mountiny. @adelekennedy Can you post the payment summary here? @allroundexperts @aimane-chnaif are the other C+ members eligible for the payout.

[JmillsExpensify]

Awaiting payment summary.

[adelekennedy]

Payouts due:

Issue Reporter: N/A
Contributor: N/A
Contributor+: $1000 @mananjadhav @allroundexperts @aimane-chnaif (NewDot)

Eligible for 50% #urgency bonus? N

[JmillsExpensify]

$1,000 payment approved for @mananjadhav based on BZ summary.

[aimane-chnaif]

@adelekennedy I am using upwork

[melvin-bot]

This issue has not been updated in over 15 days. @mananjadhav, @Swor71, @WoLewicki, @mountiny, @roryabraham, @adelekennedy, @adamgrzybowski eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

$100 to @aimane-chnaif in Upwork is that correct?

[aimane-chnaif]

yes, $1000. I haven't received offer yet.
cc: @adelekennedy

[JmillsExpensify]

$1,000 payment approved for @allroundexperts based on BZ summary.

[adelekennedy]

@aimane-chnaif - created payment issue here

[adelekennedy]

payment made!