Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task - Task is not unchecked when marked as incomplete #20285

Closed
2 of 6 tasks
kbecciv opened this issue Jun 6, 2023 · 8 comments
Closed
2 of 6 tasks

Task - Task is not unchecked when marked as incomplete #20285

kbecciv opened this issue Jun 6, 2023 · 8 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jun 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #19515

Action Performed:

Precondition: User has an existing task.

  1. Launch New Expensify app.
  2. Go to the newly created task report.
  3. Go to overflow menu > Mark as complete.
  4. Go to Parent report.
  5. Return to task report.
  6. Go to overflow menu > Mark as incomplete.
  7. Go to Parent report.s

Expected Result:

The task is unchecked when marked as incomplete.

Actual Result:

The task remains checked when marked as incomplete. It is only unchecked when the task is cancelled.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.24.4

Reproducible in staging?: yes

Reproducible in production?: no

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6082420_Screen_Recording_20230607_002103_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jun 6, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jun 6, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@neil-marcellini
Copy link
Contributor

👀 attempting to reproduce on staging and production first

@neil-marcellini
Copy link
Contributor

Reproducible on staging:
image

Not reproducible on production:
image

@neil-marcellini
Copy link
Contributor

I tried reverting #19515 locally and it didn't fix it, so I don't think that PR alone caused the problem. cc @thienlnam since you're the task master.

@thienlnam
Copy link
Contributor

Will be fixed in #20014

@neil-marcellini
Copy link
Contributor

Awesome thanks!

@neil-marcellini
Copy link
Contributor

I approved and merged the fix, and it's going to CP to staging, so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants