Production deploys can fail if a lower version is pending review

[roryabraham]

Problem

It's possible for automated production iOS deploys to fail if there's a lower version that's still pending review. For example, if 1.3.22 is still pending review, the deliver fastlane workflow will fail for 1.3.23.

Solution

Imperatively take lower versions out of review before attempting to submit a higher version for review.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a9db1bf1860d650f
• Upwork Job ID: 1667284426557599744
• Last Price Increase: 2023-06-09

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a9db1bf1860d650f

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[roryabraham]

No update

[roryabraham]

Example run: https://github.com/Expensify/App/actions/runs/5180754033

[roryabraham]

[Deliver] - Not able to reject the app version which is in Pending Developer Release

[roryabraham]

Found this fastlane plugin that supposedly does what we want: https://github.com/andrew54068/fastlane-plugin-taiwan_number_one/tree/master

[roryabraham]

Put up a PR to hopefully fix this: #21366

[parasharrajat]

I think C+ review is not needed here so unassigned.

[roryabraham]

PR was merged. It's hard to test, so I'm going to optimistically close this for now

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Release pending versions before submitting a new version for review #21366

If no regressions arise, payment will be issued on 2023-07-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[roryabraham]

Solution was reverted

[roryabraham]

No update

[roryabraham]

Not on HOLD but no update at this time.

[roryabraham]

No update, low priority. Going to just close this for now since there is a slack update to manually submit on the app stores and that only takes like a minute, so the ROI here isn't worth it.