-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some styles require a preceding whitespace while some do not #18211
Comments
Triggered auto assignment to @michaelhaxhiu ( |
Bug0 Triage Checklist (Main S/O)
|
@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@michaelhaxhiu Huh... This is 4 days overdue. Who can take care of this? |
hmm this one is a little conflicting 🤔 I think is a little inconsistent, but would be good to get engineering input on whether it's a bug or feature. This feels like a bug to me... the only time the "style" takes effect without a whitespace is when you wrap it in backticks (`). |
I'll post on the slack thread - https://expensify.slack.com/archives/C049HHMV9SM/p1683577279231859?thread_ts=1682784275.262739&cid=C049HHMV9SM |
I am not going to push this forward until we get more input form team. I'm re-assigning the label because I'm preparing to go OOO. I left this checkbox un-checked because I'm unsure about the validity of this one. Did my best to push things forward!
|
Triggered auto assignment to @strepanier03 ( |
This comment was marked as duplicate.
This comment was marked as duplicate.
I'll grab this back, working a few hours from airport and the thread post is leaning toward "this is a feature not a bug". Closing for now. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected results:
all styles should be applied in absence of a whitespace
Actual results:
only inline-code works without whitespace and others don't. No consistency is there.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.8.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
bandicam.2023-04-29.21-20-35-201.mp4
Recording.426.mp4
Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682784275262739
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: