Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some styles require a preceding whitespace while some do not #18211

Closed
6 tasks done
kavimuru opened this issue Apr 30, 2023 · 10 comments
Closed
6 tasks done

some styles require a preceding whitespace while some do not #18211

kavimuru opened this issue Apr 30, 2023 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. open a chat
  2. try bold/italics/strike-through/inline-code once with a preceding whitespace and once without that

Expected results:

all styles should be applied in absence of a whitespace

Actual results:

only inline-code works without whitespace and others don't. No consistency is there.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.8.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-04-29.21-20-35-201.mp4
Recording.426.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682784275262739

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 30, 2023
@MelvinBot
Copy link

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 30, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label May 2, 2023
@MelvinBot
Copy link

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented May 5, 2023

@michaelhaxhiu Huh... This is 4 days overdue. Who can take care of this?

@michaelhaxhiu
Copy link
Contributor

hmm this one is a little conflicting 🤔 I think is a little inconsistent, but would be good to get engineering input on whether it's a bug or feature. This feels like a bug to me... the only time the "style" takes effect without a whitespace is when you wrap it in backticks (`).

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2023
@michaelhaxhiu
Copy link
Contributor

michaelhaxhiu commented May 8, 2023

@michaelhaxhiu
Copy link
Contributor

michaelhaxhiu commented May 8, 2023

I am not going to push this forward until we get more input form team. I'm re-assigning the label because I'm preparing to go OOO.

I left this checkbox un-checked because I'm unsure about the validity of this one. Did my best to push things forward!

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)

@michaelhaxhiu michaelhaxhiu removed the Bug Something is broken. Auto assigns a BugZero manager. label May 8, 2023
@michaelhaxhiu michaelhaxhiu removed their assignment May 8, 2023
@michaelhaxhiu michaelhaxhiu added the Bug Something is broken. Auto assigns a BugZero manager. label May 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 8, 2023

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as duplicate.

@michaelhaxhiu
Copy link
Contributor

I'll grab this back, working a few hours from airport and the thread post is leaning toward "this is a feature not a bug". Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants